feat(core-p2p): improve incoming WS message check + IP banning on worker#3331
Merged
faustbrian merged 3 commits intomasterfrom Dec 9, 2019
Merged
feat(core-p2p): improve incoming WS message check + IP banning on worker#3331faustbrian merged 3 commits intomasterfrom
faustbrian merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve incoming WS message check by discarding too small messages (no need to even try to JSON parse those).
IP banning on worker for errors at WS level (no need to call master, we shut down socket and ban the IP for 1 minute).
Use
prependListenerfor our WS message listeners so that our listeners are called before SC ones.Checklist