Skip to content

feat(core-p2p): improve incoming WS message check + IP banning on worker#3331

Merged
faustbrian merged 3 commits intomasterfrom
master-p2p-worker-msg-check-ip-banning
Dec 9, 2019
Merged

feat(core-p2p): improve incoming WS message check + IP banning on worker#3331
faustbrian merged 3 commits intomasterfrom
master-p2p-worker-msg-check-ip-banning

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Dec 9, 2019

Summary

Improve incoming WS message check by discarding too small messages (no need to even try to JSON parse those).

IP banning on worker for errors at WS level (no need to call master, we shut down socket and ban the IP for 1 minute).

Use prependListener for our WS message listeners so that our listeners are called before SC ones.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low labels Dec 9, 2019
@faustbrian faustbrian merged commit 94766ea into master Dec 9, 2019
@ghost ghost deleted the master-p2p-worker-msg-check-ip-banning branch December 9, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants