Skip to content

fix(core-p2p): edge cases handling#3404

Merged
faustbrian merged 10 commits intomasterfrom
master-patch-p2p
Jan 21, 2020
Merged

fix(core-p2p): edge cases handling#3404
faustbrian merged 10 commits intomasterfrom
master-patch-p2p

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Jan 21, 2020

Summary

  • Discard blocks containing too many transactions
  • Disconnect when multiple sockets are opened from same IP
  • Handle invalid WS opcodes
  • Disconnect for p2p SocketCluster events that do not have a handler
  • Handle payload with additional properties

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

faustbrian
faustbrian previously approved these changes Jan 21, 2020
View reviewed changes
@faustbrian faustbrian merged commit 99eded0 into master Jan 21, 2020
@ghost ghost deleted the master-patch-p2p branch January 21, 2020 06:28
@ghost ghost mentioned this pull request Jan 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

1 more reviewer

@faustbrian faustbrian faustbrian left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@air1one @faustbrian