refactor(crypto): remove long dependency#3502
Merged
faustbrian merged 7 commits into2.6from Feb 17, 2020
Merged
Conversation
added 4 commits
February 14, 2020 05:55
Codecov Report
@@ Coverage Diff @@
## 2.6 #3502 +/- ##
==========================================
+ Coverage 66.13% 66.14% +<.01%
==========================================
Files 439 439
Lines 12460 12464 +4
Branches 1711 1711
==========================================
+ Hits 8241 8244 +3
- Misses 4185 4186 +1
Partials 34 34
Continue to review full report at Codecov.
|
air1one
previously approved these changes
Feb 14, 2020
added 2 commits
February 14, 2020 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
long@3dependency can cause problems if people also havelong@4installed because node.js will think it should uselong@4even though we don't have it as a dependency. This will cause thevalue instanceof Longcheck in thebytebufferdependency to fail because its own dependency islong@3but node.js will force it to uselong@4if it is installed, which will throw an exception because the instance signatures will differ.The
bytebuffertypes have been removed because they don't reflect their JavaScript code. The types state that you can only pass in anumberorLongbut their code will actually perform assertions and useLonginternally to create an instance. This means that whatever long version is installed will be used.