refactor(core-magistrate): allow multiple ports in bridgechain schema#3504
Merged
faustbrian merged 7 commits into2.6from Feb 24, 2020
Merged
refactor(core-magistrate): allow multiple ports in bridgechain schema#3504faustbrian merged 7 commits into2.6from
faustbrian merged 7 commits into2.6from
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.6 #3504 +/- ##
======================================
Coverage ? 66.15%
======================================
Files ? 440
Lines ? 12479
Branches ? 1715
======================================
Hits ? 8256
Misses ? 4189
Partials ? 34
Continue to review full report at Codecov.
|
Contributor
Author
|
Still need to make the "pattern properties" of the ports schema more specific, only including chars that could actually be in a package name. |
because AJV has unwanted behavior with patternProperties
faustbrian
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow to register multiple ports in bridgechain registration / update, instead of only core-api.
Checklist