Skip to content

refactor(core-magistrate): allow multiple ports in bridgechain schema#3504

Merged
faustbrian merged 7 commits into2.6from
refactor/magistrate/multiple-ports
Feb 24, 2020
Merged

refactor(core-magistrate): allow multiple ports in bridgechain schema#3504
faustbrian merged 7 commits into2.6from
refactor/magistrate/multiple-ports

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Feb 14, 2020

Summary

Allow to register multiple ports in bridgechain registration / update, instead of only core-api.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (2.6@941f776). Click here to learn what that means.
The diff coverage is 61.11%.

Impacted file tree graph

@@          Coverage Diff           @@
##             2.6    #3504   +/-   ##
======================================
  Coverage       ?   66.15%           
======================================
  Files          ?      440           
  Lines          ?    12479           
  Branches       ?     1715           
======================================
  Hits           ?     8256           
  Misses         ?     4189           
  Partials       ?       34
Impacted Files Coverage Δ
packages/core-p2p/src/peer-connector.ts 67.44% <ø> (ø)
packages/core/src/utils.ts 0% <0%> (ø)
...ges/crypto/src/transactions/types/multi-payment.ts 100% <100%> (ø)
packages/crypto/src/transactions/types/transfer.ts 100% <100%> (ø)
packages/crypto/src/blocks/serializer.ts 83.67% <100%> (ø)
packages/core-database/src/database-service.ts 25.41% <100%> (ø)
packages/crypto/src/transactions/serializer.ts 88.72% <100%> (ø)
...ackages/crypto/src/transactions/types/htlc-lock.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f776...386bcce. Read the comment docs.

@air1one
Copy link
Copy Markdown
Contributor Author

air1one commented Feb 14, 2020

Still need to make the "pattern properties" of the ports schema more specific, only including chars that could actually be in a package name.

@faustbrian faustbrian merged commit 239f12e into 2.6 Feb 24, 2020
@ghost ghost deleted the refactor/magistrate/multiple-ports branch February 24, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants