Skip to content

refactor(core-transaction-pool): no default addonBytes for magistrate transactions#3560

Merged
faustbrian merged 1 commit into2.6from
refactor/addonbytes-magistrate
Mar 2, 2020
Merged

refactor(core-transaction-pool): no default addonBytes for magistrate transactions#3560
faustbrian merged 1 commit into2.6from
refactor/addonbytes-magistrate

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Mar 2, 2020

Summary

Resolves #3539

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2020

Codecov Report

Merging #3560 into 2.6 will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.6    #3560   +/-   ##
=======================================
  Coverage   66.13%   66.14%           
=======================================
  Files         440      440           
  Lines       12480    12480           
  Branches     1717     1717           
=======================================
+ Hits         8254     8255    +1     
+ Misses       4192     4191    -1     
  Partials       34       34           
Impacted Files Coverage Δ
...-transactions/src/handlers/business-resignation.ts 58.53% <0.00%> (ø) ⬆️
packages/core-transaction-pool/src/storage.ts 100.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98394c...e9f4659. Read the comment docs.

@faustbrian faustbrian changed the title refactor(core-transaction-pool): no default addonBytes for magistrate txs refactor(core-transaction-pool): no default addonBytes for magistrate transactions Mar 2, 2020
@faustbrian faustbrian merged commit 980f3f5 into 2.6 Mar 2, 2020
@ghost ghost deleted the refactor/addonbytes-magistrate branch March 2, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants