refactor(core-blockchain): reset missedBlocks before await call#3598
Merged
faustbrian merged 1 commit into2.6from Mar 13, 2020
Merged
refactor(core-blockchain): reset missedBlocks before await call#3598faustbrian merged 1 commit into2.6from
faustbrian merged 1 commit into2.6from
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.6 #3598 +/- ##
=======================================
Coverage 66.06% 66.07%
=======================================
Files 441 441
Lines 12506 12506
Branches 1716 1716
=======================================
+ Hits 8262 8263 +1
+ Misses 4211 4210 -1
Partials 33 33
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset missedBlocks before await call in checkMissingBlocks.
Reason for that is the await call takes a bit of time, during which checkMissingBlocks can be called various times. If missedBlocks is not reset before it, we can end up calling this await checkNetworkHealth() a lot of times for nothing.
Checklist