Skip to content

fix(core-blockchain): allow transition to fork from idle#3614

Merged
faustbrian merged 1 commit into2.6from
fix/core-blockchain/idle-fork
Mar 25, 2020
Merged

fix(core-blockchain): allow transition to fork from idle#3614
faustbrian merged 1 commit into2.6from
fix/core-blockchain/idle-fork

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Mar 24, 2020

Summary

Allow transition to fork from idle state, as the ForgerMissing event can be triggered while being idle.

Also implement a 10min delay between each potential checkNetworkHealth as when downloading blocks we can trigger a lot of ForgerMissing events.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2020

Codecov Report

Merging #3614 into 2.6 will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3614      +/-   ##
==========================================
+ Coverage   66.07%   66.08%   +0.01%     
==========================================
  Files         441      441              
  Lines       12506    12511       +5     
  Branches     1716     1717       +1     
==========================================
+ Hits         8263     8268       +5     
  Misses       4210     4210              
  Partials       33       33              
Impacted Files Coverage Δ
...ackages/core-blockchain/src/machines/blockchain.ts 100.00% <ø> (ø)
packages/core-blockchain/src/blockchain.ts 66.82% <100.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b079cb6...4f8ce5b. Read the comment docs.

@faustbrian faustbrian merged commit f779485 into 2.6 Mar 25, 2020
@ghost ghost deleted the fix/core-blockchain/idle-fork branch March 25, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants