fix(core-state): update vote balance with htlc locked balance on vote transactions#3669
Merged
faustbrian merged 2 commits into2.6from Apr 28, 2020
Merged
fix(core-state): update vote balance with htlc locked balance on vote transactions#3669faustbrian merged 2 commits into2.6from
faustbrian merged 2 commits into2.6from
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.6 #3669 +/- ##
==========================================
- Coverage 66.08% 66.02% -0.06%
==========================================
Files 441 443 +2
Lines 12511 12643 +132
Branches 1717 1757 +40
==========================================
+ Hits 8268 8348 +80
- Misses 4210 4262 +52
Partials 33 33
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When updating the vote balance on a vote/unvote transaction, we were not taking the potential sender locked balance.
This fixes it.
Checklist