Skip to content

fix(core-state): update vote balance with htlc locked balance on vote transactions#3669

Merged
faustbrian merged 2 commits into2.6from
fix/htlc-lock-vote-balance
Apr 28, 2020
Merged

fix(core-state): update vote balance with htlc locked balance on vote transactions#3669
faustbrian merged 2 commits into2.6from
fix/htlc-lock-vote-balance

Conversation

@air1one
Copy link
Copy Markdown
Contributor

@air1one air1one commented Apr 28, 2020

Summary

When updating the vote balance on a vote/unvote transaction, we were not taking the potential sender locked balance.
This fixes it.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2020

Codecov Report

Merging #3669 into 2.6 will decrease coverage by 0.05%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3669      +/-   ##
==========================================
- Coverage   66.08%   66.02%   -0.06%     
==========================================
  Files         441      443       +2     
  Lines       12511    12643     +132     
  Branches     1717     1757      +40     
==========================================
+ Hits         8268     8348      +80     
- Misses       4210     4262      +52     
  Partials       33       33              
Impacted Files Coverage Δ
.../core-jest-matchers/src/functional/vote-balance.ts 0.00% <0.00%> (ø)
packages/core-state/src/wallets/wallet-manager.ts 90.76% <100.00%> (+0.03%) ⬆️
packages/core-transaction-pool/src/memory.ts 95.23% <0.00%> (-3.43%) ⬇️
packages/core-elasticsearch/src/indices/rounds.ts 0.00% <0.00%> (ø)
packages/core-utils/src/tree.ts 65.68% <0.00%> (ø)
packages/core-transaction-pool/src/connection.ts 92.46% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5dc31...216e74f. Read the comment docs.

@faustbrian faustbrian merged commit b0296e7 into 2.6 Apr 28, 2020
@ghost ghost deleted the fix/htlc-lock-vote-balance branch April 28, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants