Correct a few Neon entries - #452
Merged
Merged
Conversation
This includes: - mfloat8 is limited to A64 always - vcreate_mf8 lowers to FMOV for both gcc and clang - vcombine_mf8 and vget_high_mf8 have optimized sequences they lower to. I'm quite certain I saw at least one of them lowering to zip1 for gcc, but mov is what LLVM picks and sort of equivalent in a way - vget_low_mf8 can be optimized to a NOP - Replace some lower case letters with upper case ones where appropriate - Fix some arg mappings (e.g. "arrangement specifiers")
rockdreamer
reviewed
Aug 18, 2026
rockdreamer
left a comment
rockdreamer
left a comment
Contributor
There was a problem hiding this comment.
One nit but LGTM other than that
rockdreamer
reviewed
Aug 18, 2026
rockdreamer
approved these changes
Sep 2, 2026
The surrounding (related) intrinsics of the ones that I changed in this commit compile to the same instrs. Hence, this change in this PR might be a bit too much and we should leave it like it is probably.
We should leave the instr similar to the others. Every other instr maps to a NOP as well and this means we would technically need to change the entire column. These instrs. are semantically equivalent, because they just do an extra copy step to a destination register while the compilers optimize the sequence to just return from the input reg directly.
rockdreamer
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes: