refactor(apps): centralize shared app definitions#384
Merged
prashymh merged 1 commit intoARM-software:mainfrom May 1, 2026
Merged
refactor(apps): centralize shared app definitions#384prashymh merged 1 commit intoARM-software:mainfrom
prashymh merged 1 commit intoARM-software:mainfrom
Conversation
Move shared app-level constants and declarations out of the target-specific baremetal and UEFI acs.h headers. Add shared headers for: - ACS app version macros - suite level defaults and bounds - common app info-table helper declarations Use the shared definitions from baremetal, UEFI, and Linux userspace app code, and remove duplicate version, level, software-view, and print-format macros where the shared definition is now available. Move shared runtime globals to acs_cfg.h and remove duplicate local externs from app headers and VAL sources. Align baremetal createRasInfoTable() with the UEFI signature by returning the val_ras_create_info_table() status, then centralize its declaration with the other shared table helpers. Keep target-specific definitions, table sizes, and startup settings in their existing target headers. Change-Id: I420e5218e3c245140048a21fd8f640708e59330c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move shared app-level constants and declarations out of the target-specific baremetal and UEFI acs.h headers.
Add shared headers for:
Use the shared definitions from baremetal, UEFI, and Linux userspace app code, and remove duplicate version, level, software-view, and print-format macros where the shared definition is now available.
Move shared runtime globals to acs_cfg.h and remove duplicate local externs from app headers and VAL sources. Align baremetal createRasInfoTable() with the UEFI signature by returning the val_ras_create_info_table() status, then centralize its declaration with the other shared table helpers.
Keep target-specific definitions, table sizes, and startup settings in their existing target headers.
Change-Id: I420e5218e3c245140048a21fd8f640708e59330c