Add Linux generic support #26
Conversation
|
Thank you for your contribution. I will have a look at this shortly! |
|
hmmm, let me consult my lawyer :-) |
|
;) PS: I can merge it after TechCon (mid of November) most probably because for now we have a feature freeze on this software. |
There was a problem hiding this comment.
there should be also _ in end of detection pattern, like:
"^/[a-zA-Z0-9/]*/" + dev_name + " on (/[a-zA-Z0-9_/]*) ".
This because looks that when multiple devices are connected mount point will be
/media/MBED_for second device/media/MBED__for third device
and so on.../media/MBED______...
.
There was a problem hiding this comment.
You're right, but that's another issue. Anyway I need to rebase this branch (carefully) because there have been other changes to the code (that I extracted) in the meantime.
There was a problem hiding this comment.
@jupe - I think you should open a separate PR about your pattern change for multiple devices.
There was a problem hiding this comment.
yep, it was in original code too, so this need to be done in separate PR.
|
@PrzemekWirkus I signed the contributor agreement. |
The new Linux generic support is actually the original code from lstools_ubuntu. Now MbedLsToolsUbuntu inherits from MbedLsToolsLinuxGeneric (to allow Ubuntu-specific changes in the future).
|
I pushed this again rebased on top of current master branch. |
Add Linux generic support
3 participants
The new Linux generic support is actually the original code from
lstools_ubuntu.Now
MbedLsToolsUbuntuinherits fromMbedLsToolsLinuxGeneric(to allow Ubuntu-specific changes in the future). Supposedly since they are identical we can remove the Ubuntu-specific class which adds no functionality right now, but I understand the mbed dev team wants to keep Ubuntu separate.I tested this on RHEL 6.7 with Freescale FRDM-K64F.
Maybe solves #25.