Skip to content

Bugfixes#200

Merged
MarleneBusch merged 9 commits into
mainfrom
bugfix/bitmap_e_u
Apr 27, 2026
Merged

Bugfixes#200
MarleneBusch merged 9 commits into
mainfrom
bugfix/bitmap_e_u

Conversation

@MarleneBusch

@MarleneBusch MarleneBusch commented Apr 27, 2026

Copy link
Copy Markdown
Member

Description

This fixes bugs in the e and u bitmap and tensor system.
This also fixes loading wgs84 coordinates as float64 consistently.
It also fixes the kinematic reconstruction for heliostats with ideal actuators (they dont have optimizable actuator parameters, only optimizable rotation deviations.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.06%. Comparing base (0ed84bf) to head (3ec0d92).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
artist/core/kinematics_reconstructor.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   96.09%   96.06%   -0.04%     
==========================================
  Files          48       48              
  Lines        3948     3961      +13     
==========================================
+ Hits         3794     3805      +11     
- Misses        154      156       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown
Name Stmts Miss Cover Missing
artist\__init__.py 5 0 100%
artist\core\__init__.py 5 0 100%
artist\core\blocking.py 283 9 97% 378, 380, 552-555, 598-599, 728, 743, 981
artist\core\core_utils.py 6 0 100%
artist\core\heliostat_ray_tracer.py 166 1 99% 329
artist\core\kinematics_reconstructor.py 125 16 87% 160, 310-311, 468-478, 533-556
artist\core\learning_rate_schedulers.py 32 1 97% 179
artist\core\loss_functions.py 69 0 100%
artist\core\motor_position_optimizer.py 164 13 92% 323-333, 487, 585-592, 650-659
artist\core\regularizers.py 26 0 100%
artist\core\surface_reconstructor.py 160 12 92% 546-554, 645-663
artist\data_parser\__init__.py 0 0 100%
artist\data_parser\calibration_data_parser.py 42 2 95% 197-202
artist\data_parser\h5_scenario_parser.py 148 5 97% 568, 572, 578, 583, 588
artist\data_parser\paint_calibration_parser.py 66 0 100%
artist\data_parser\paint_scenario_parser.py 195 0 100%
artist\data_parser\stral_scenario_parser.py 41 0 100%
artist\field\__init__.py 14 0 100%
artist\field\actuators.py 16 0 100%
artist\field\actuators_ideal.py 9 0 100%
artist\field\actuators_linear.py 57 0 100%
artist\field\heliostat_field.py 115 0 100%
artist\field\heliostat_group.py 52 0 100%
artist\field\heliostat_group_rigid_body.py 23 0 100%
artist\field\kinematics.py 13 0 100%
artist\field\kinematics_rigid_body.py 67 0 100%
artist\field\solar_tower.py 48 0 100%
artist\field\surface.py 21 0 100%
artist\field\tower_target_areas.py 15 0 100%
artist\field\tower_target_areas_cylindrical.py 40 0 100%
artist\field\tower_target_areas_planar.py 32 0 100%
artist\scenario\__init__.py 5 0 100%
artist\scenario\configuration_classes.py 203 0 100%
artist\scenario\h5_scenario_generator.py 83 30 64% 117-141, 153-161, 185, 192-197, 215-218
artist\scenario\scenario.py 93 2 98% 209, 428
artist\scenario\surface_generator.py 87 0 100%
artist\scene\__init__.py 5 0 100%
artist\scene\light_source.py 11 0 100%
artist\scene\light_source_array.py 28 0 100%
artist\scene\rays.py 7 0 100%
artist\scene\sun.py 43 0 100%
artist\util\__init__.py 53 18 66% 37-71
artist\util\config_dictionary.py 303 0 100%
artist\util\environment_setup.py 110 23 79% 89-91, 186-228, 308
artist\util\index_mapping.py 322 0 100%
artist\util\nurbs.py 155 20 87% 215-248, 408, 412, 414-415, 566-567, 570-571
artist\util\raytracing_utils.py 91 0 100%
artist\util\type_mappings.py 11 0 100%
artist\util\utils.py 296 4 99% 513, 912, 958, 1138
TOTAL 3961 156 96%

@MarleneBusch MarleneBusch marked this pull request as ready for review April 27, 2026 12:58
@MarleneBusch MarleneBusch requested a review from mcw92 April 27, 2026 12:59

@mcw92 mcw92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍. Just as a note: I did not check the generate_results script in detail so far. I will do this once we have a final version after restructuring the package and publishing a new ARTIST version.

@MarleneBusch MarleneBusch merged commit 5ed8f21 into main Apr 27, 2026
12 checks passed
@MarleneBusch MarleneBusch deleted the bugfix/bitmap_e_u branch April 27, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants