Move interface/enum family out-of-line into MLIRGenInterfaces.cpp (§1)#225
Merged
Conversation
…view doc 1) 12 methods (EnumDeclaration, interface info/heritage/declaration, field/method members, generic interface registration, object interface vtables, method-name helpers) move from MLIRGenImpl.h into a new MLIRGenInterfaces.cpp TU; header keeps declarations. 810 lines out of the header (14212 -> 13402). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 TU split continues — same pattern as #217–#224.
12 methods move from
MLIRGenImpl.hinto a newMLIRGenInterfaces.cppTU:mlirGen(EnumDeclaration), bothmlirGenInterfaceInfooverloads,mlirGenInterfaceHeritageClauseExtends,mlirGen(InterfaceDeclaration),mlirGenInterfaceAddFieldMember(default arg preserved on declaration),mlirGenInterfaceMethodMember,registerGenericInterface,mlirGenCreateInterfaceVTableForObject,mlirGenObjectVirtualTableDefinitionForInterface, and the sharedgetNameForMethod/getMethodNameOrPropertyNamehelpers.Test plan
test-compile-00-for-await, untouched by this change; it passes solo and in its 3-test group on re-run (first flake observed in nine full-suite runs, likely transient under-j8load)🤖 Generated with Claude Code