Remove stale disabled-test comments and re-enable already-fixed tests - #291
Merged
Merged
Conversation
Three TODO/disabled-test comments described bugs that were already fixed
(2026-07-05, see jit-globals-not-gc-roots and coro-dynamic-alloca-print-crash
history) but never got cleaned up:
- test-compile-Raytrace / test-jit-Raytrace: "TODO: find out why it is
crashing" - fixed via GC_add_roots registration for JIT'd globals.
- test-compile-00-for-await-yield: was commented out entirely ("TODO: in opt
mode, error") - fixed via heap-allocating string-concat scratch buffers
inside presplit coroutines instead of a dynamic stack alloca. Re-enabled.
- test-jit-00-for-await-yield: had a stale comment describing the same
now-fixed coroutine crash above an already-enabled, already-passing test.
817/817 tests green (816 + newly re-enabled test-compile-00-for-await-yield).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-compile-Raytrace/test-jit-Raytrace: drop stale "TODO: find out why it is crashing" comments — fixed 2026-07-05 (JIT'd globals weren't registered as Boehm GC roots).test-compile-00-for-await-yield: re-enable (was fully commented out) — fixed the same day (dynamic stack alloca inside a presplit coroutine forced to heap allocation instead).test-jit-00-for-await-yield: drop a stale comment describing the same now-fixed crash above an already-enabled, already-passing test.No production code changes — comment/registration cleanup only, found while reviewing test coverage after #290.
Test plan
ctest -C Debug -j 8: 817/817 passed (816 + newly re-enabled test)🤖 Generated with Claude Code