[50] ensure multi-realm-scoped value in the nodeRequestScopedFeaturesStoreFactory export of the features package #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
TomStrepsil
changed the title
rename of nodeRequestScopedFeaturesStoreFactory
TomStrepsil
changed the title
…scoped-features-store-factory
…scoped-features-store-factory Update danger-js to avoid vulns
asos-dominicjomaa
approved these changes
Oct 21, 2025
TomStrepsil
deleted the
feature/50-ensure-realm-scoped-node-request-scoped-features-store-factory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #50
Details
FeaturesStoreFactoryinterface, mandating that all features stores are created with a namedtoggleTypenodeRequestScopedFeaturesStoreFactorythis is used to key the features store against a a runtime-wide global symbol to ensure it can be shared in cross-realm runtimes (e.g. NextJS). Hence, there can only be a single features store per namedtoggleType, for this store type. Seeexpress-http-contextfor similar.nameproperty thereactContextFeaturesStoreFactory, required previously to provide a nicedisplayNamefor the react context provider. Its also used to form part of theidof the backing script for thessrBackedReactContextFeaturesStoreFactoryScout Rule
nodeRequestScopedStoreFactorytonodeRequestScopedFeaturesStoreFactory, for consistencyvaltioexamples in theREADME.mddanger-jsto latest version, to mitigate GHSA-8g77-54rh-46hx and GHSA-xx4v-prfh-6cgcUpgrade guide
This change will represent breaking changes in consumers of the features package.
Any use of stores now require a
toggleTypeproperty, replacing thenamethat may have come before. It should represent the type of toggle, e.g."experiments".Any name import of
nodeRequestScopedStoreFactoryshould now importnodeRequestScopedFeaturesStoreFactoryCheckList
main.