Skip to content

Fix incorrect authentication url - #30

Merged
mattmassicotte merged 1 commit into
ATProtoKit:mainfrom
pnewell:patch-1
Apr 3, 2025
Merged

Fix incorrect authentication url#30
mattmassicotte merged 1 commit into
ATProtoKit:mainfrom
pnewell:patch-1

Conversation

@pnewell

@pnewell pnewell commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Fix incorrect authentication url (was using request url but instead should be using the redirectURL that we get back from google)

Fix incorrect authentication url (was using request url but instead should be using the redirectURL that we get back from google)
@mattmassicotte

Copy link
Copy Markdown
Contributor

I had to make some substantial changes a while ago, and I must have broken this at that point. Thank you for finding it and fixing it. Hopefully it didn't cause you too much trouble along the way.

@mattmassicotte
mattmassicotte merged commit af90c5b into ATProtoKit:main Apr 3, 2025
@martindufort

martindufort commented Apr 4, 2025 via email

Copy link
Copy Markdown
Contributor

@mattmassicotte

Copy link
Copy Markdown
Contributor

No, I don't think so. I had to introduce some new concepts that added some naming ambiguity. I tried my best to keep these correct, but I think I missed a few spots.

@martindufort

Copy link
Copy Markdown
Contributor

Just looked at my version and yes there is a lot of changes... That's my loginProvider()

	static func loginProvider() -> TokenHandling.LoginProvider {
		return { url, appCredentials, tokenURL, urlLoader in
			let request = try authenticationRequest(url: url, appCredentials: appCredentials)

			let (data, _) = try await urlLoader(request)
        ...

And you did a lot of changes to support SwiftConcurrency.
Need to setup time to upgrade but only after iPhone launch 🥵🥵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants