Fix incorrect authentication url - #30
Merged
Merged
Conversation
Fix incorrect authentication url (was using request url but instead should be using the redirectURL that we get back from google)
Contributor
|
I had to make some substantial changes a while ago, and I must have broken this at that point. Thank you for finding it and fixing it. Hopefully it didn't cause you too much trouble along the way. |
Contributor
|
Was it always like this ? Authentication URL?
…On Thu, Apr 3, 2025 at 3:42 PM Matt Massicotte ***@***.***> wrote:
I had to make some substantial changes a while ago, and I must have broken
this at that point. Thank you for finding it and fixing it. Hopefully it
didn't cause you too much trouble along the way.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4YD4OZZ5IFQNWWPJZ3V3D2XWFI7AVCNFSM6AAAAAB2NBC5BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZWG42TSMRYGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: mattmassicotte]*mattmassicotte* left a comment
(ATProtoKit/OAuthenticator#30)
<#30 (comment)>
I had to make some substantial changes a while ago, and I must have broken
this at that point. Thank you for finding it and fixing it. Hopefully it
didn't cause you too much trouble along the way.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4YD4OZZ5IFQNWWPJZ3V3D2XWFI7AVCNFSM6AAAAAB2NBC5BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZWG42TSMRYGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
|
No, I don't think so. I had to introduce some new concepts that added some naming ambiguity. I tried my best to keep these correct, but I think I missed a few spots. |
Contributor
|
Just looked at my version and yes there is a lot of changes... That's my static func loginProvider() -> TokenHandling.LoginProvider {
return { url, appCredentials, tokenURL, urlLoader in
let request = try authenticationRequest(url: url, appCredentials: appCredentials)
let (data, _) = try await urlLoader(request)
...And you did a lot of changes to support SwiftConcurrency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect authentication url (was using request url but instead should be using the redirectURL that we get back from google)