Fix nullable, required fields#55
Merged
hipstersmoothie merged 1 commit intoJul 7, 2026
Merged
Conversation
This is a follow up to ATProtocol-CommunityGH-52, which caused `goat` to emit warnings. Goat does not want fields to be nullable *and* optional. But either nullable and required. Or non-nullable and optional. See: <https://github.com/bluesky-social/indigo/blob/dfe5578f/lex/lexlint/lint.go#L330-L340>. Related-to ATProtocol-CommunityGH-52. This also regenerates the `bundle.ts` which picks up a change that landed over the weekend without updating.
Contributor
Author
|
Tests and type checks pass locally. Also: I see pre-existing lint/formatting stuff? |
hipstersmoothie
merged commit 1d19617
into
ATProtocol-Community:main
3 of 5 checks passed
Collaborator
|
Published! |
wooorm
added a commit
to wooorm/eurosky-portal
that referenced
this pull request
Jul 7, 2026
* bsky images 1mb -> 2mb * atstore fixes (ATProtocol-Community/ATStore#55) * misc
wooorm
added a commit
to eurosky-social/eurosky-portal
that referenced
this pull request
Jul 7, 2026
* bsky images 1mb -> 2mb * atstore fixes (ATProtocol-Community/ATStore#55) * misc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to GH-52, which caused
goatto emit warnings.
Goat does not want fields to be nullable and optional. But either nullable and required. Or non-nullable and optional.
See: https://github.com/bluesky-social/indigo/blob/dfe5578f/lex/lexlint/lint.go#L330-L340.
Related-to GH-52.
This also regenerates the
bundle.tswhich picks up a change that landed over the weekend without updating.