ci: install nightly before stable in the publish job - #3
Merged
Conversation
`dtolnay/rust-toolchain` makes the toolchain it installs the default, so installing nightly last left every unpinned `cargo` in `scripts/check.sh` running under nightly. The v0.6.0 publish died on `cargo clippy` -- nightly has no clippy -- and `coverage` would have died next on the missing llvm-tools. Nightly goes first now, carrying only the rustfmt that `cargo +nightly fmt` asks for by name, and stable lands last as the default with the two components the action's minimal profile does not ship. CI never caught this because each gate there gets its own job and its own toolchain; the publish job is the only place they share one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.0 publish run failed 29s in:
dtolnay/rust-toolchainmakes whichever toolchain it installs the default. Thepublish job installed stable and then nightly, so every unpinned
cargoinscripts/check.sh allran under nightly.clippywas simply the first gate tonotice;
coveragewould have been next, on the llvm-tools the minimal profiledoes not ship either.
Nightly is installed first now, carrying only the rustfmt that
cargo +nightly fmtasks for by name, and stable lands last as the default withclippy, llvm-tools-previewexplicit.CI never caught this: there, each gate is its own job with its own toolchain.
The publish job is the only place a single job runs every gate.
Verified locally against the release ref --
GITHUB_REF_NAME=v0.6.0 scripts/check.sh allpasses the full set (fmt, clippy, test, doc, doctest,deny, coverage at 80.21%, release).