Add regression tests for LiDAR hits, CV/FastBEV perception, and control dual-write - #31
Draft
cursor[bot] wants to merge 3 commits into
Draft
Add regression tests for LiDAR hits, CV/FastBEV perception, and control dual-write#31cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Cover empty scenes, boundary and agent BB hits, range misses, and nearest-hit selection so silent ray math regressions fail fast. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Lock down the default predictor horizon/heading math and FastBEV segmentation, diagonal gating, edge-on default boxes, and z-band filter. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Regression coverage for Control Step/Steer after the world/stack ego split: plant advances then pm.ego_vehicle is copied in place. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused regression coverage for high-risk paths that remained untested on
dev, while avoiding duplication of open drafts #17/#20/#22–#30.Risky behavior now covered
BasicSimLiDAR raycasting: empty scenes; forward hits on boundary walls and agent BB near faces; misses beyondc46_lidar_range; nearest-hit selection when wall and agent both intersect a rayConstantVelocityPrediction.predict: empty-agent clear; horizon/heading extrapolation keyed byagent_id;Noneperception model raisesFastBEVLidarDetection.detect: gap >musplits clusters; diagonal outside[delta_min, delta_max]dropped; edge-on/collinear clusters get default L/W boxes pushed away from ego; 3D z-band filter clears/accepts pointsVisualizerApp.apply_world_control: after world/stack ego split, Control Step/Steer advances the plant then copies intopm.ego_vehiclein placeTest files added/updated
test/c40_execution/test_c46_basic_sim_lidar.py(new)test/c10_perception/test_c15_constant_velocity_prediction.py(new)test/c10_perception/test_c15_fast_bev_detection.py(new)test/plugins/test_p60_visualizer_tk/test_p61_apply_global_plan.pyWhy these tests materially reduce regression risk
BasicSim LiDAR feeds FTG, FastBEV, and lidar localization in the default sim bridge—silent ray math bugs corrupt every LiDAR consumer. Constant-velocity prediction is the default predictor in bundled profiles; wrong horizon/heading changes lattice and velocity collision sweeps. FastBEV is the active detector in
perception.yamlwith complex segmentation/MBR edge cases.apply_world_controlis the merged fix path for Control Step/Steer desync after the world/stack ego split.Validation
All 17 tests passed. No production code changes.