Fix pipeline velocity corrupting global speeds and mid-track path origin - #34
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix pipeline velocity corrupting global speeds and mid-track path origin#34cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…th origin. VelocityLocalPlanner.plan_velocity now profiles a copy so LocalPlanningPipeline cannot permanently zero the shared global reference. ReferencePathPlanner emits the forward horizon from current_wp instead of the full route from s=0. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Global reference speeds permanently zeroed — With
LocalPlanningPipeline+VelocityLocalPlannerand an empty path stage,plan_velocityprofiled the shared globalTrajectoryTrackerin place. After braking for an obstacle, clearing the obstacle left the global velocities at 0, so the ego never resumed cruise.Mid-track local path started at the origin —
ReferencePathPlanner.plan_pathcopied the full route from s=0 withtrajectory=None, so the velocity stage / controllers rebuilt a tracker atcurrent_wp=0while ego was mid-route (e.g. after a corner). Local plans aimed at the wrong segment and emergency-braked.Root cause
LocalPlan.from_trajectoryaliases the live global tracker; velocity profiling mutates it.ReferencePathPlanneravoided that alias but still emitted geometry from route start.VelocityLocalPlanner.replanalready cloned viaslice_trajectory_horizon; the pipeline velocity stage did not.Fix
VelocityLocalPlanner.plan_velocityprofiles a copy (path/velocity/waypoints/boundaries).ReferencePathPlanner.plan_pathemits the forward horizon fromcurrent_wp(slice_trajectory_horizon(..., max_points=0)).Validation
31 passed (includes new regressions for global-speed preservation and mid-track reference path).
Not re-reported (still open)