fix(observer): capture active window via NSWorkspace, not osascript (beat 20)#258
Merged
Merged
Conversation
…beat 20)
The observer polled but captured nothing — active_window={}, so "what was I
doing?" could only say "saw nothing." Root cause: _get_active_window used
osascript/System Events (Automation permission), and macOS TCC attributes that
subprocess to the PM2/node launcher, not the granted python3.13 — so the daemon
never got a value even after the operator granted Automation.
Fix: get the app name + pid from NSWorkspace.frontmostApplication() (a public
API needing NO TCC permission — works from a background daemon) and the focused
window title from Quartz CGWindowList (uses the already-granted Screen Recording
permission the observer uses for OCR). osascript kept as a headless/CI fallback.
Verified as the daemon's framework Python: {} → {'app':'Claude','title':'Claude'}.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AVADSA25
added a commit
that referenced
this pull request
Jul 16, 2026
) DEMO_SCRIPT.md had been rewritten locally (the 15→22→25-beat seal, performance reorder, name-drop moats table) but was never actually committed — it sat as an uncommitted edit in the shared working tree since 2026-07-14. Committing the full sealed version now, plus today's status refresh: - #21 self-improve: now fully conversational (#257), no longer "fix in progress" - #20 observer recall: fully fixed — routing (#256), real NSWorkspace capture (#258), honest on out-of-range clock-time asks (#260) - #14 Pilot: navigation confirmed live; live-view click-through flagged as a rebuild in progress (was mis-marked READY) - #19 Connector: OAuth sign-in itself confirmed working; connected/disconnect state + persistent tokens flagged as a rebuild in progress - #18: note to set the CODEC connector to Always Allow in Claude's settings Co-authored-by: Mickael Farina <farina.mickael@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The observer (
codec-observer) polled but captured nothing —~/.codec/observer_buffer.jsonentries hadactive_window: {}, so beat 20 ("what was I doing?") could only honestly say it saw nothing.Root cause (proven)
_get_active_window()usedosascript→ System Events (Automation permission). macOS TCC attributes that subprocess to the PM2/node launcher, not the grantedpython3.13, so the daemon's Framework Python got{}even after the operator granted Automation + Screen Recording. (_get_active_window()run as that exact python returned{}; a plain shell osascript returned the app.)Fix
NSWorkspace.sharedWorkspace().frontmostApplication()— public API, no TCC permission, works from a background daemon.Quartz.CGWindowListCopyWindowInfo— uses the already-granted Screen Recording permission (the observer's OCR path)._get_active_window_osascript).Verify
As the daemon's framework Python:
{}→{'app':'Google Chrome','title':'… - Gmail'}.py_compile+ ruff clean, 52 observer tests pass. After merge +pm2 restart codec-observer+ one poll, the buffer fills and "what was I doing?" returns a real timeline.🤖 Generated with Claude Code