[#632] Fix SWIG incompatibility between dataFileToViz and vizInterface#1382
Merged
schaubh merged 4 commits intoMay 1, 2026
Merged
Conversation
…terface dataFileToViz SWIG file defines SWIG type wrappers that are incompatible to the ones defined in vizInterface. Some combinations of dataFileToViz and vizInterface imports will thus cause usage of one to fail due to generic SwigPyObjects getting emitted instead of the proper wrappers.
Add a fresh-interpreter unit test that verifies dataFileToViz and vizInterface shared ThrClusterMap wrappers work in both import orders. Also add the release note snippet for the PR.
Contributor
|
Thanks @sassy-asjp for the solution to this issue. I added a unit test to check this behavior, and added a release notes snippet. Could you please check my unit test to ensure you agree with this test? |
Contributor
Author
|
Thanks, I think that makes sense! |
schaubh
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dataFileToViz SWIG file defines SWIG type wrappers that are incompatible to the ones defined in vizInterface. Some combinations of dataFileToViz and vizInterface imports will thus cause usage of one to fail due to generic SwigPyObjects getting emitted instead of the proper wrappers.
I modified the SWIG wrappers to be compatible.
Verification
The failing combination of tests now pass
Documentation
None
Future work
None