Check pip upgrade return code #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Characters in stderr don't necessarily mean an error. Rather, a call to process.returncode should check for a success 0, or error code 1 (or otherwise).
patkenneally
force-pushed
the
ci/bsk-458--check-pip-process-returncode
branch
from
96c6a19 to
7f19f55
Compare
thibaudteil
approved these changes
Oct 18, 2023
schaubh
force-pushed
the
ci/bsk-458--check-pip-process-returncode
branch
from
7f19f55 to
db0f615
Compare
schaubh
approved these changes
Oct 19, 2023
Contributor
schaubh
left a comment
schaubh
left a comment
There was a problem hiding this comment.
fixed some small RST formatting issue. I updated the BSK release notes on this branch already. Good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On line 310 in conanfile.py the Basilisk directory is pip installed. This line interprets any output to stderr (returned in the err variable) as an error. However, characters in stderr don't necessarily mean an error (it's sometimes simply a warning). Rather, this line should call process.returncode and check for a success 0, or error code 1 or otherwise.
Verification
CI will run successfully.
Documentation
None needed, none invalidated.
Future work
The follow on work that gave rise to this change is coming in #459.