Skip to content

Check pip upgrade return code #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Check pip upgrade return code #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2941e9
Check pip upgrade return code
patkenneally Oct 18, 2023
db0f615
Update release notes
patkenneally Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,12 @@ def add_basilisk_to_sys_path(self):

process = subprocess.Popen(add_basilisk_module_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
output, err = process.communicate()
if err:
if process.returncode:
print("Error %s while running %s" % (err.decode(), add_basilisk_module_command))
sys.exit(1)
else:
print("This resulted in the output: \n%s" % output.decode())
print("This resulted in the stdout: \n%s" % output.decode())
print("This resulted in the stderr: \n%s" % err.decode())

if __name__ == "__main__":
parser = argparse.ArgumentParser(description="Configure the Basilisk framework.")
Expand Down
8 changes: 5 additions & 3 deletions docs/source/Support/bskReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@ Version |release|
and angular rate (optional) are within the requirement limits and sends an imaging command to a :ref:`simpleInstrument`.
- Added a new scenario :ref:`scenarioHohmann` that performs a Hohmann transfer with attitude mode changes.
The basic attitude flight modes are implemented using the Basilisk event system.
- updated conan support to latest `1.xx` version to provide support for macOS Sonoma
- updated macOS `cspice` library to be compiled with Xcode 15. This addresses some errors that appeared
when calling the prior pre-built `cspice` library. The new library is backwards compatible with
- updated conan support to latest ``1.xx`` version to provide support for macOS Sonoma
- updated macOS ``cspice`` library to be compiled with Xcode 15. This addresses some errors that appeared
when calling the prior pre-built ``cspice`` library. The new library is backwards compatible with
prior versions of Xcode.
- Fixed a bug in the conanfile where the ``stderr`` output from a ``subprocess.Popen`` call was being interpreted as an
error. Rather, the process return code (0 for success, and anything else for failure) indicates the success.


Version 2.2.0 (June 28, 2023)
Expand Down