[fix-zip-observable] synchronize ZipObservable onComplete implementation#1
Merged
lpetka merged 1 commit intoseries/3.x-avsfrom May 20, 2025
Merged
[fix-zip-observable] synchronize ZipObservable onComplete implementation#1lpetka merged 1 commit intoseries/3.x-avsfrom
lpetka merged 1 commit intoseries/3.x-avsfrom
Conversation
…ions in order to avoid reading stale shared state in multithreaded environment
sebaciv
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipObservable implementations (all flavors
Zip{2,3,4,5,6}Observable) uses shared state in multithreaded environment. There was a problem with underterministically non completing observables which was induced by the read of a non-volatile shared boolean without prior memory barrier.I wasn't able to reproduce the problem on a current monix fork and the reason behind it is still unknown to me, although the major contributors might be:
The problem is reproducing kinda well for a current DHCP implementation both in testing suites and production code (the executor provided for the observable is irrelevant there).
Playground: https://gitlab.avsystem.com/csp/dslam/dhcp/-/commit/ca08ccb46078c6f8e8cde3f1261d51527e2f39d1