Skip to content

[fix-zip-observable] synchronize ZipObservable onComplete implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpetka merged 1 commit into from
May 20, 2025
Merged

[fix-zip-observable] synchronize ZipObservable onComplete implementation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions monix-reactive/shared/src/main/scala/monix/reactive/internal/builders/Zip2Observable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ private[reactive] final class Zip2Observable[A1, A2, +R](obsA1: Observable[A1],
def onError(ex: Throwable): Unit =
signalOnError(ex)
def onComplete(): Unit =
signalOnComplete(hasElemA1)
lock.synchronized(signalOnComplete(hasElemA1))
})

composite += obsA2.unsafeSubscribeFn(new Subscriber[A2] {
Expand All @@ -176,7 +176,7 @@ private[reactive] final class Zip2Observable[A1, A2, +R](obsA1: Observable[A1],
def onError(ex: Throwable): Unit =
signalOnError(ex)
def onComplete(): Unit =
signalOnComplete(hasElemA2)
lock.synchronized(signalOnComplete(hasElemA2))
})

composite
Expand Down
6 changes: 3 additions & 3 deletions monix-reactive/shared/src/main/scala/monix/reactive/internal/builders/Zip3Observable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ private[reactive] final class Zip3Observable[A1, A2, A3, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA1)
lock.synchronized(signalOnComplete(hasElemA1))
})

composite += obsA2.unsafeSubscribeFn(new Subscriber[A2] {
Expand All @@ -186,7 +186,7 @@ private[reactive] final class Zip3Observable[A1, A2, A3, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA2)
lock.synchronized(signalOnComplete(hasElemA2))
})

composite += obsA3.unsafeSubscribeFn(new Subscriber[A3] {
Expand All @@ -209,7 +209,7 @@ private[reactive] final class Zip3Observable[A1, A2, A3, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA3)
lock.synchronized(signalOnComplete(hasElemA3))
})

composite
Expand Down
8 changes: 4 additions & 4 deletions monix-reactive/shared/src/main/scala/monix/reactive/internal/builders/Zip4Observable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private[reactive] final class Zip4Observable[A1, A2, A3, A4, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA1)
lock.synchronized(signalOnComplete(hasElemA1))
})

composite += obsA2.unsafeSubscribeFn(new Subscriber[A2] {
Expand All @@ -192,7 +192,7 @@ private[reactive] final class Zip4Observable[A1, A2, A3, A4, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA2)
lock.synchronized(signalOnComplete(hasElemA2))
})

composite += obsA3.unsafeSubscribeFn(new Subscriber[A3] {
Expand All @@ -215,7 +215,7 @@ private[reactive] final class Zip4Observable[A1, A2, A3, A4, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA3)
lock.synchronized(signalOnComplete(hasElemA3))
})

composite += obsA4.unsafeSubscribeFn(new Subscriber[A4] {
Expand All @@ -238,7 +238,7 @@ private[reactive] final class Zip4Observable[A1, A2, A3, A4, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA4)
lock.synchronized(signalOnComplete(hasElemA4))
})

composite
Expand Down
10 changes: 5 additions & 5 deletions monix-reactive/shared/src/main/scala/monix/reactive/internal/builders/Zip5Observable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ private[reactive] final class Zip5Observable[A1, A2, A3, A4, A5, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA1)
lock.synchronized(signalOnComplete(hasElemA1))
})

composite += obsA2.unsafeSubscribeFn(new Subscriber[A2] {
Expand All @@ -198,7 +198,7 @@ private[reactive] final class Zip5Observable[A1, A2, A3, A4, A5, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA2)
lock.synchronized(signalOnComplete(hasElemA2))
})

composite += obsA3.unsafeSubscribeFn(new Subscriber[A3] {
Expand All @@ -221,7 +221,7 @@ private[reactive] final class Zip5Observable[A1, A2, A3, A4, A5, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA3)
lock.synchronized(signalOnComplete(hasElemA3))
})

composite += obsA4.unsafeSubscribeFn(new Subscriber[A4] {
Expand All @@ -244,7 +244,7 @@ private[reactive] final class Zip5Observable[A1, A2, A3, A4, A5, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA4)
lock.synchronized(signalOnComplete(hasElemA4))
})

composite += obsA5.unsafeSubscribeFn(new Subscriber[A5] {
Expand All @@ -267,7 +267,7 @@ private[reactive] final class Zip5Observable[A1, A2, A3, A4, A5, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA5)
lock.synchronized(signalOnComplete(hasElemA5))
})

composite
Expand Down
12 changes: 6 additions & 6 deletions monix-reactive/shared/src/main/scala/monix/reactive/internal/builders/Zip6Observable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA1)
lock.synchronized(signalOnComplete(hasElemA1))
})

composite += obsA2.unsafeSubscribeFn(new Subscriber[A2] {
Expand All @@ -204,7 +204,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA2)
lock.synchronized(signalOnComplete(hasElemA2))
})

composite += obsA3.unsafeSubscribeFn(new Subscriber[A3] {
Expand All @@ -227,7 +227,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA3)
lock.synchronized(signalOnComplete(hasElemA3))
})

composite += obsA4.unsafeSubscribeFn(new Subscriber[A4] {
Expand All @@ -250,7 +250,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA4)
lock.synchronized(signalOnComplete(hasElemA4))
})

composite += obsA5.unsafeSubscribeFn(new Subscriber[A5] {
Expand All @@ -273,7 +273,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA5)
lock.synchronized(signalOnComplete(hasElemA5))
})

composite += obsA6.unsafeSubscribeFn(new Subscriber[A6] {
Expand All @@ -296,7 +296,7 @@ private[reactive] final class Zip6Observable[A1, A2, A3, A4, A5, A6, +R](
signalOnError(ex)

def onComplete(): Unit =
signalOnComplete(hasElemA6)
lock.synchronized(signalOnComplete(hasElemA6))
})

composite
Expand Down