feat(add-orchestrator): install-time divergence detection (--check + overwrite-prompt wiring) (#8) - #13
Merged
Merged
Conversation
…ode + overwrite-prompt wiring (#8) Re-running /add-orchestrator offered overwrite/skip/cancel per skill with no version comparison, no diff, and no detection of local customization. Two real failures came from that: a hand-written routing directive that a plain overwrite would have silently destroyed, and two skills sitting ahead of the bundle for weeks with nothing comparing the two directions (#5). Add a read-only `--check` mode that, per installed runtime skill, reports the three states — installed < bundled (upgrade available), installed > bundled (back-port candidate), installed == bundled but content differs (local customization) — in the canon-doctor PASS/WARN/FAIL shape with a one-line fleet-readable verdict. Step 4's per-skill overwrite prompt calls the same comparison, so the warning arrives at the moment of decision, not after. Deliberately scoped to add-orchestrator's own bundle and stateless (no new on-disk registry). Plugin-framework-wide version filed as a follow-up. add-orchestrator 1.20 -> 1.22 (skips 1.21, reserved for open PR #9); agent-dev plugin 1.14.0 -> 1.14.2 (skips 1.14.1, reserved for #9). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vybe
force-pushed
the
fix/8-install-divergence-check
branch
from
August 17, 2026 14:13
0a4ebe2 to
c3340e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8 (add-orchestrator-scoped version; framework-wide follow-up is #12).
(Supersedes PR #11, which was auto-closed when its branch was rebuilt — the original branch had accidentally been stacked on a stray #5 commit from a prior aborted run, pulling
sync-fleet-to-head.mdinto the diff. This branch is rebased clean ontomain: exactly the two files below.)Problem
Re-running
/add-orchestratoroffered overwrite / skip / cancel per skill with no version comparison, no diff, and no detection that a local copy was customized. Two real failures this week:/orchestratecarried a hand-written marketing-hierarchy routing block (Eugene directive). A plain overwrite would have destroyed it silently — it had to be re-applied by hand.What this adds
A read-only
--checkmode on/add-orchestratorthat, per installed runtime skill, reports the three states — and wires the same comparison into Step 4's overwrite prompt so the warning arrives at the moment of decision, not after:installed < bundledinstalled > bundledinstalled == bundled, content differsinstalled == bundled, identicalReported in the canon-doctor PASS/WARN/FAIL shape with a one-line fleet-readable verdict (orchestrators dispatch it fleet-wide and read only that line). Version compare is numeric-per-component (
1.9 < 1.13), tested against all four states end-to-end.Deliberately left out (minimal scope, per Eugene's ruling)
Overlap with PR #9 (issue #7) — still OPEN, not yet merged
#9 also bumps this skill and
agent-dev/plugin.json. To avoid a version collision I skip 1.21 / 1.14.1 (reserved for #9): add-orchestrator1.20 -> 1.22, agent-dev plugin1.14.0 -> 1.14.2. Whichever merges second will hit a mechanical conflict on theSKILL.mdfrontmatter (changelog prepend) andplugin.jsonversion line — both trivial to reconcile. No template files touched here, so #9's body changes don't overlap.Files changed:
plugins/agent-dev/skills/add-orchestrator/SKILL.md,plugins/agent-dev/.claude-plugin/plugin.json.🤖 Generated with Claude Code