Skip to content

bug(ci): frontend-e2e 'changes' path-filter hard-fails on PRs >300 files — every release PR shows a red X #1782

Description

@vybe

The changes job in frontend-e2e.yml detects frontend changes via:

gh pr diff <n> --repo Abilityai/trinity --name-only

GitHub's diff API refuses PRs whose diff exceeds 300 files (HTTP 406 PullRequest.diff too_large), so the job exits 1 and the whole workflow reports failure — with e2e/report skipped, not run.

First hit: release PR #1781 (v0.8.5, 619 files). Every future release PR (routinely 500+ files) will show the same red X. Introduced with the #1526 rework (the job predates >300-file PRs reaching it).

Fix options

  • Use the paginated files API instead: gh api repos/{owner}/{repo}/pulls/{n}/files --paginate --jq '.[].filename'
  • Or checkout + git diff --name-only "origin/${{ github.base_ref }}"...HEAD
  • Either way, treat "cannot determine changed files" as frontend=true (fail-open into running the suite), not job failure.

Not a required check on main, so v0.8.5 shipped past it — but the red X on a release PR is noise we shouldn't normalize.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions