You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The project was once "docs marketplace". The name is gone from the UI, but it is still the identifier prefix across the whole contract and codebase, and it collides with unrelated AbsaOSS projects:
marketplace.json, bundle.json, field marketplaceVersion (unified by #74)
HTML attribute
data-mp-headless="true" on <html>
CSS classes
.mp-doc, .mp-single-page, other mp-* in src/styles/marketplace.css, src/templates/shadow-compat.js, the single-page action's template.js
Env var
MP_HEADLESS (read via isHeadlessBuild())
Stylesheet
src/styles/marketplace.css, "marketplace CSS" alias logic in build-vite.js
Prose
"marketplace" throughout contract/*.md, README.md, AGENTS.md, CLAUDE.md, comments, nginx config comments, test names
Roughly 25 source files, plus the contract documents and both actions.
Proposal: hard cut, kb prefix everywhere
Old
New
data-mp-headless
data-kb-headless
mp-* CSS classes
kb-*
MP_HEADLESS
KB_HEADLESS
marketplaceVersion
kbVersion (owned by #74; listed here for completeness)
src/styles/marketplace.css
src/styles/knowledge-base.css
"marketplace" in prose
"knowledge base"
No compatibility shim. Nothing is in production, the single-page action is the only producer of single-page HTML, and packaged repos republish through #76, which verifies the new attribute. The knowledge-base build warns on data-mp-headless with a message saying the artifact was produced against the old contract, exactly as it warns on a missing attribute today, so a stale release is diagnosable rather than silently accepted.
--color-kb-* design tokens already use the kb prefix; this brings everything else in line with them.
Scope
transform.js, hoist-inline-scripts.js, fetch-apps.js, build-vite.js, Base.astro, [...path].astro, shadow-compat.js: attribute, class and env names
src/utils/config.js: isHeadlessBuild() reads KB_HEADLESS; package.json scripts and scripts/build-vite.js export the new name
src/styles/knowledge-base.css renamed; the dist/style.css alias logic in build-vite.js keeps working (it identifies the stylesheet by what the landing page loads, not by filename, so this should be a rename only — verify with the existing build-integrity test)
actions/publish-single-page-docs/src/template.js emits data-kb-headless and kb-doc
git grep -i marketplace and git grep -E -- '\bmp[-_]' return nothing outside git history
Sequencing
Touches the same files as #74 / #75. Do it either first, as a pure mechanical rename before the behavioural changes, or last, after they merge — not in parallel.
Part of #73.
Problem
The project was once "docs marketplace". The name is gone from the UI, but it is still the identifier prefix across the whole contract and codebase, and it collides with unrelated AbsaOSS projects:
dist.tar.gz(renamed by #74)marketplace.json,bundle.json, fieldmarketplaceVersion(unified by #74)data-mp-headless="true"on<html>.mp-doc,.mp-single-page, othermp-*insrc/styles/marketplace.css,src/templates/shadow-compat.js, the single-page action'stemplate.jsMP_HEADLESS(read viaisHeadlessBuild())src/styles/marketplace.css, "marketplace CSS" alias logic inbuild-vite.jscontract/*.md,README.md,AGENTS.md,CLAUDE.md, comments, nginx config comments, test namesRoughly 25 source files, plus the contract documents and both actions.
Proposal: hard cut,
kbprefix everywheredata-mp-headlessdata-kb-headlessmp-*CSS classeskb-*MP_HEADLESSKB_HEADLESSmarketplaceVersionkbVersion(owned by #74; listed here for completeness)src/styles/marketplace.csssrc/styles/knowledge-base.cssNo compatibility shim. Nothing is in production, the single-page action is the only producer of single-page HTML, and packaged repos republish through #76, which verifies the new attribute. The knowledge-base build warns on
data-mp-headlesswith a message saying the artifact was produced against the old contract, exactly as it warns on a missing attribute today, so a stale release is diagnosable rather than silently accepted.--color-kb-*design tokens already use thekbprefix; this brings everything else in line with them.Scope
transform.js,hoist-inline-scripts.js,fetch-apps.js,build-vite.js,Base.astro,[...path].astro,shadow-compat.js: attribute, class and env namessrc/utils/config.js:isHeadlessBuild()readsKB_HEADLESS;package.jsonscripts andscripts/build-vite.jsexport the new namesrc/styles/knowledge-base.cssrenamed; thedist/style.cssalias logic inbuild-vite.jskeeps working (it identifies the stylesheet by what the landing page loads, not by filename, so this should be a rename only — verify with the existingbuild-integritytest)actions/publish-single-page-docs/src/template.jsemitsdata-kb-headlessandkb-doctests/*.spec.js,tests/support/fragment.js,scripts/setup-test-apps.mjs,tests/fragment-server.mjs, fixtures regeneratednginx.conf/nginx.headers.confcomments;DockerfilecommentsREADME.md,AGENTS.md,CLAUDE.mdAbsaOSS/knowledge-base-docs-example:theme/main.htmlsetsdata-kb-headless, prose updated (goes with its migration in actions/publish-docs: one reusable action that validates, packs and publishes kb-docs.tar.gz for packaged doc sites #76)git grep -i marketplaceandgit grep -E -- '\bmp[-_]'return nothing outside git historySequencing
Touches the same files as #74 / #75. Do it either first, as a pure mechanical rename before the behavioural changes, or last, after they merge — not in parallel.