fix: Enhance masthead for compact mode with brand visibility - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the masthead component to support a more compact layout on app pages and introduces a brand wordmark display. The main changes involve conditional rendering and new CSS rules to visually distinguish between the library and app pages.
Masthead layout improvements:
mp-masthead) now conditionally applies amp-masthead--compactclass when viewing an app page, resulting in a more streamlined appearance with only the navigation strip visible.mp-masthead-brand) is displayed in the left gutter on larger screens, while the eyebrow, title, and description elements are hidden for clarity. [1] [2]Styling enhancements:
.mp-masthead--compactand.mp-masthead-brandto control layout, spacing, and responsive behavior, ensuring the brand is only shown on larger screens and the masthead adapts appropriately.Release notes:
Related: