spline #1009 Remove obsolete producer model v1.1#1010
Merged
Conversation
AdrianOlosutean
previously approved these changes
Jan 27, 2022
| <!-- deprecated models --> | ||
|
|
||
| <dependency> | ||
| <groupId>za.co.absa.spline</groupId> |
Contributor
There was a problem hiding this comment.
Why still keeping this?
Contributor
Author
There was a problem hiding this comment.
Both Kafka and REST endpoints of Spline Producer API provide backward compatibility with some of the older models via the model mapper. The concrete models are defined as optional dependencies for the mapper, thus the client modules have to explicitly declare what models they actually support.
Contributor
|
The build is falling Looks like there is still wrong dependecny somewhere? |
wajda
force-pushed
the
feature/spline-1009-remove-model-v1.1
branch
from
b4a557c to
2e7c7d9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cerveada
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
producer-model-v1.1module toproducer-model-v1.2