Skip to content

spline #1009 Remove obsolete producer model v1.1 #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wajda merged 1 commit into from
Feb 1, 2022
Merged

spline #1009 Remove obsolete producer model v1.1 #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions kafka-gateway/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,28 @@
</dependency>
<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>producer-model-v1.1</artifactId>
<artifactId>producer-model-mapper</artifactId>
<version>${project.version}</version>
</dependency>

<!-- current model -->

<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>producer-model-mapper</artifactId>
<artifactId>producer-model-v1.2</artifactId>
<version>${project.version}</version>
</dependency>

<!-- deprecated models -->

<dependency>
<groupId>za.co.absa.spline</groupId>
Copy link
Copy Markdown
Contributor

@AdrianOlosutean AdrianOlosutean Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why still keeping this?

Copy link
Copy Markdown
Contributor Author

@wajda wajda Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Kafka and REST endpoints of Spline Producer API provide backward compatibility with some of the older models via the model mapper. The concrete models are defined as optional dependencies for the mapper, thus the client modules have to explicitly declare what models they actually support.

<artifactId>producer-model-v1.1</artifactId>
<version>0.7.5</version>
</dependency>

<!-- other deps -->

<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka</artifactId>
Expand Down
19 changes: 17 additions & 2 deletions producer-model-mapper/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,35 @@
<dependencies>
<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>producer-model-v1.1</artifactId>
<artifactId>commons</artifactId>
<version>${project.version}</version>
</dependency>

<!-- current model -->

<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>commons</artifactId>
<artifactId>producer-model-v1.2</artifactId>
<version>${project.version}</version>
</dependency>

<!-- deprecated models -->

<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>producer-model-v1.1</artifactId>
<version>0.7.5</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>za.co.absa.spline</groupId>
<artifactId>producer-model</artifactId>
<version>0.5.1</version>
<optional>true</optional>
</dependency>

<!-- other deps -->

<dependency>
<groupId>io.bfil</groupId>
<artifactId>automapper_${scala.compat.version}</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion producer-model/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<version>1.0.0-SNAPSHOT</version>
</parent>

<artifactId>producer-model-v1.1</artifactId>
<artifactId>producer-model-v1.2</artifactId>

<dependencies>
<dependency>
Expand Down
72 changes: 0 additions & 72 deletions producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/AttrOrExprRef.scala
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/Attribute.scala
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/ExecutionEvent.scala
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/executionPlan.scala
View file
Open in desktop

This file was deleted.

73 changes: 0 additions & 73 deletions producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/expressions.scala
View file
Open in desktop

This file was deleted.

Loading