Skip to content

[VkShaderGen] Emit layout blocks for stage in/out#2273

Closed
ashwinbhat wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
autodesk-forks:bhata/vkshadergen_fix
Closed

[VkShaderGen] Emit layout blocks for stage in/out#2273
ashwinbhat wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
autodesk-forks:bhata/vkshadergen_fix

Conversation

@ashwinbhat
Copy link
Copy Markdown
Contributor

Update the Vulkan shadergen to emit layout blocks for stage interfaces.
old output:

layout (location = 0) out vec3 normalWorld;
layout (location = 1) out vec3 tangentWorld;
layout (location = 2) out vec3 positionWorld;

new output

layout (location = 0) out VertexData
{
    vec3 normalWorld;
    vec3 tangentWorld;
    vec3 positionWorld;
} vd;

Also fixes #2271

Update the Vulkan shadergen to emit layout blocks for stage interfaces.
e.g
layout (location = 0) out VertexData
{
    vec3 normalWorld;
    vec3 tangentWorld;
    vec3 positionWorld;
} vd;

layout (location = 0) in VertexData
{
    vec3 normalWorld;
    vec3 tangentWorld;
    vec3 positionWorld;
} vd;
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 11, 2025

CLA Missing ID CLA Not Signed

@ashwinbhat ashwinbhat closed this Mar 11, 2025
@ashwinbhat ashwinbhat deleted the bhata/vkshadergen_fix branch March 11, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GenVK: Generated shader is invalid

1 participant