Static analysis optimizations#2349
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Apr 14, 2025
jstone-lucasfilm:main
Merged
Static analysis optimizations#2349jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom jstone-lucasfilm:main
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm:main
Conversation
This changelist addresses a handful of recommendations from PVS-Studio, replacing `std::vector::push_back` with `std::vector::emplace_back` to minimize string copies.
jstone-lucasfilm
merged commit 9f7adc3
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist addresses a handful of recommendations from PVS-Studio, replacing
std::vector::push_backwithstd::vector::emplace_backto minimize string copies.