Adsk Contrib - Fix grading inversion #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
…e instead of from_reference) Signed-off-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com>
michdolan
approved these changes
Jan 6, 2021
Member
|
As discussed at the last TSC meeting, I will merge the pull request (that's the last one needed) to prepare |
hodoulp
approved these changes
Jan 6, 2021
frankieeder
pushed a commit
to frankieeder/OpenColorIO
that referenced
this pull request
Jan 21, 2021
* Fix grading op inversion Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Fix dyn prop equality Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * RGB curve inverse Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add curve slopes Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add serialization test Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add frozen python docs Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Adjust tests after merge from master (v2 is using from_scene_reference instead of from_reference) Signed-off-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com> Co-authored-by: Bernard Lefebvre <37628108+BernardLefebvre@users.noreply.github.com> Signed-off-by: Frankie Eder <frankaeder@gmail.com>
frankieeder
pushed a commit
to frankieeder/OpenColorIO
that referenced
this pull request
Jan 21, 2021
* Fix grading op inversion Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Fix dyn prop equality Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * RGB curve inverse Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add curve slopes Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add serialization test Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Add frozen python docs Signed-off-by: Doug Walker <Doug.Walker@autodesk.com> * Adjust tests after merge from master (v2 is using from_scene_reference instead of from_reference) Signed-off-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com> Co-authored-by: Bernard Lefebvre <37628108+BernardLefebvre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the GradingPrimary op inverse and implements the inverses in GradingTone and GradingRGBCurve.
Fixes a bug related to dynamic property comparison.
Allows slopes to be provided for RGB Curves.