Skip to content

fix(oiiotool): -d SUBIMAGENAME.* didn't work properly#5048

Merged
lgritz merged 2 commits intoAcademySoftwareFoundation:mainfrom
lgritz:lg-format
Feb 26, 2026
Merged

fix(oiiotool): -d SUBIMAGENAME.* didn't work properly#5048
lgritz merged 2 commits intoAcademySoftwareFoundation:mainfrom
lgritz:lg-format

Conversation

@lgritz
Copy link
Collaborator

@lgritz lgritz commented Feb 15, 2026

The docs described a syntax where you could use -d to change the data type of all channels in one subimage of a multi-subimage image. But it didn't work, as revealed in #5047.

Fixes #5047

The docs described a syntax where you could use `-d` to change the
data type of all channels in one subimage of a multi-subimage image.
But it didn't work, as revealed in 5047.

Fixes 5047

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Feb 19, 2026

@MrLixm Can you confirm that this fixes your problem reported in #5047, and ideally look over the patch and approve (or make further suggestions)? Thanks.

@MrLixm
Copy link

MrLixm commented Feb 19, 2026

I am not familiar with the C++ syntax but logic looks good !
The test cases match my use cases (but maybe it would be worth to add a test case that cover the subimage{:02} trick ?)

…ize it by 'subimage{:02}'

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz
Copy link
Collaborator Author

lgritz commented Feb 19, 2026

maybe it would be worth to add a test case that cover the subimage{:02} trick ?

Good suggestion. I have amended the PR with such a test.

@lgritz
Copy link
Collaborator Author

lgritz commented Feb 26, 2026

2 weeks, no objections, confirmed as fix by original issue reporter --> merging.

@lgritz lgritz merged commit 21dbd07 into AcademySoftwareFoundation:main Feb 26, 2026
30 checks passed
@lgritz lgritz deleted the lg-format branch February 26, 2026 13:56
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Feb 27, 2026
…areFoundation#5048)

The docs described a syntax where you could use `-d` to change the data
type of all channels in one subimage of a multi-subimage image. But it
didn't work, as revealed in AcademySoftwareFoundation#5047.

Fixes AcademySoftwareFoundation#5047

---------

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: (oiiotool) -d don't work with <subimagename>

2 participants