fix(texture): fix texture overblur with st-blur parameters by lecocqp · Pull Request #5071 · AcademySoftwareFoundation/OpenImageIO

lecocqp · 2026-03-05T01:53:15Z

Fixes #5069

This PR fixes the texture blur overstimate reported in #5069

We provide the following changes:

Use the mathematically correct Pythagorean form to properly adjust the ellispse footprint with st-blur parameters.
Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders.
Add a new --fix-texture-blur option in testtex to enable the fix.
Add a new texture-blurfix test.

Note: This PR has been partially edited using the Claude coding assistant.

Checklist:

I have read the guidelines on contributions and code review procedures.
I have updated the documentation if my PR adds features or changes
behavior.
I am sure that this PR's changes are tested somewhere in the
testsuite.
I have run and passed the testsuite in CI before submitting the
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
My code follows the prevailing code style of this project and I
fixed any problems reported by the clang-format CI test.
If I added or modified a public C++ API call, I have also amended the
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.

linux-foundation-easycla · 2026-03-05T01:53:22Z

The committers listed above are authorized under a signed CLA.

✅ login: lecocqp / name: Pascal Lecocq (2ab30fb, 9a73c69, ad0e8d9, b205367, dbef624, f88a271)
✅ login: lgritz / name: Larry Gritz (3b254ae)

lecocqp · 2026-03-06T22:21:43Z

@lgritz, I think the PR is in good shape now and ready for review.

Last changes provided:

Rename the TextureSystem fix_texture_blur attribute to legacy_texture_blur and default it to false
Rename testtex option to --legacy-texture-blur and default it to false.
Modify texture-blurfix test to check the fixed blur and the old legacy blur.

lgritz · 2026-03-06T22:32:53Z

@lecocqp Can you rebase on top of the current main, I think I have fixed a number of pesky intermittent CI failures that are unrelated to your changes.

lgritz · 2026-03-06T22:38:48Z

src/libtexture/imagecache.cpp

+    } else if (name == "legacy_texture_blur" && type == TypeDesc::INT) {
+        m_legacy_texture_blur = (*(const int*)val != 0);


I suspect that the new field and handling of it should be in the TextureSystem and not in the ImageCache?

There is a division of labor here, and things specific to texture filtering go in the TextureSystem, while things related the file reads and tile caching policy are part of the ImageCache. Requests to the TS to set attributes in the underlying IC are just passed down transparently, so that from the renderer level, you can just set texturesys->attribute(...) and not need to know what lives where.

lgritz

Other than my comment about in which class the new field should live, it LGTM

lecocqp · 2026-03-07T00:41:43Z

I moved the new legacy_texture_blur attribute handling in TextureSystemImpl as you suggested.

I also rebased my branch on top of main, but I'm still seeing some CI failures.

lgritz · 2026-03-07T00:58:01Z

I also rebased my branch on top of main, but I'm still seeing some CI failures.

Random CI failures have really been kicking my ass all week. These don't seem to be related to your PR.

src/libtexture/texture_pvt.h

lgritz

LGTM!

I'll merge as soon as CI is finished. (And pending your acceptance of my #if suggestion.)

src/libtexture/texture_pvt.h

lgritz · 2026-03-07T04:07:08Z

Holy shit, why does every edit seem to fail MORE tests in CI, and none of them are related to this PR as near as I can tell? What is happening to the GitHub runners?

This PR fixes the texture blur overstimate reported in AcademySoftwareFoundation#5069 We provide the following changes: * Use the mathematically correct Pythagorean form to properly adjust the ellispse extents. * Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders. * Add a new --fix-texture-blur option in testtex to enable the fix. * Add a new texture-blurfix test. Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

…xture_blur` and default it to false * Rename testtex option to `--legacy-texture-blur` and default it to false. * Modify texture-blurfix test to check the fixed correct blur and the old legacy blur. Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Co-authored-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Signed-off-by: Larry Gritz <lg@larrygritz.com>

lgritz · 2026-03-07T08:59:32Z

I rebased this again, in the hopes that on top of the other fixes I merged, we'll finally pass CI. If it does, I will merge it as well.

…ftwareFoundation#5071) Fixes AcademySoftwareFoundation#5069 This PR fixes the texture blur overstimate reported in AcademySoftwareFoundation#5069 We provide the following changes: * Use the mathematically correct Pythagorean form to properly adjust the ellispse footprint with st-blur parameters. * Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders. * Add a new --fix-texture-blur option in testtex to enable the fix. * Add a new texture-blurfix test. Note: This PR has been partially edited using the Claude coding assistant. --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

The m_legacy_texture_blur flag is set in TextureSystemImpl::Init, which overrides the default initialisation depending on the OIIO version. In other words, the texture blur fix was always enabled, regardless of the OIIO version. I also updated the help description for this flag in testtex. This fixes minor shortcomings of #5071 --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

…ndation#5080) The m_legacy_texture_blur flag is set in TextureSystemImpl::Init, which overrides the default initialisation depending on the OIIO version. In other words, the texture blur fix was always enabled, regardless of the OIIO version. I also updated the help description for this flag in testtex. This fixes minor shortcomings of AcademySoftwareFoundation#5071 --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

…ftwareFoundation#5071) Fixes AcademySoftwareFoundation#5069 This PR fixes the texture blur overstimate reported in AcademySoftwareFoundation#5069 We provide the following changes: * Use the mathematically correct Pythagorean form to properly adjust the ellispse footprint with st-blur parameters. * Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders. * Add a new --fix-texture-blur option in testtex to enable the fix. * Add a new texture-blurfix test. Note: This PR has been partially edited using the Claude coding assistant. --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

…ndation#5080) The m_legacy_texture_blur flag is set in TextureSystemImpl::Init, which overrides the default initialisation depending on the OIIO version. In other words, the texture blur fix was always enabled, regardless of the OIIO version. I also updated the help description for this flag in testtex. This fixes minor shortcomings of AcademySoftwareFoundation#5071 --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>

…ftwareFoundation#5071) Fixes AcademySoftwareFoundation#5069 This PR fixes the texture blur overstimate reported in AcademySoftwareFoundation#5069 We provide the following changes: * Use the mathematically correct Pythagorean form to properly adjust the ellispse footprint with st-blur parameters. * Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders. * Add a new --fix-texture-blur option in testtex to enable the fix. * Add a new texture-blurfix test. Note: This PR has been partially edited using the Claude coding assistant. --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>

…ndation#5080) The m_legacy_texture_blur flag is set in TextureSystemImpl::Init, which overrides the default initialisation depending on the OIIO version. In other words, the texture blur fix was always enabled, regardless of the OIIO version. I also updated the help description for this flag in testtex. This fixes minor shortcomings of AcademySoftwareFoundation#5071 --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>

…ftwareFoundation#5071) Fixes AcademySoftwareFoundation#5069 This PR fixes the texture blur overstimate reported in AcademySoftwareFoundation#5069 We provide the following changes: * Use the mathematically correct Pythagorean form to properly adjust the ellispse footprint with st-blur parameters. * Add a new legacy_texture_blur attribute in TextureSystem to opt into the fix without breaking existing renders. * Add a new --fix-texture-blur option in testtex to enable the fix. * Add a new texture-blurfix test. Note: This PR has been partially edited using the Claude coding assistant. --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>

…ndation#5080) The m_legacy_texture_blur flag is set in TextureSystemImpl::Init, which overrides the default initialisation depending on the OIIO version. In other words, the texture blur fix was always enabled, regardless of the OIIO version. I also updated the help description for this flag in testtex. This fixes minor shortcomings of AcademySoftwareFoundation#5071 --------- Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>

lecocqp changed the title ~~fix(texture): fix~~ fix(texture): fix texture overblur with st-blur parameters Mar 5, 2026

lecocqp force-pushed the fix-texture-blur-overestimate branch 6 times, most recently from c2a8f95 to 51c2b9b Compare March 5, 2026 22:41

lgritz reviewed Mar 6, 2026

View reviewed changes

lgritz requested changes Mar 6, 2026

View reviewed changes

lecocqp force-pushed the fix-texture-blur-overestimate branch 2 times, most recently from 11afd1b to 93e1e4b Compare March 7, 2026 00:22

lecocqp requested a review from lgritz March 7, 2026 00:37

lgritz reviewed Mar 7, 2026

View reviewed changes

src/libtexture/texture_pvt.h Show resolved Hide resolved

lgritz approved these changes Mar 7, 2026

View reviewed changes

lgritz reviewed Mar 7, 2026

View reviewed changes

src/libtexture/texture_pvt.h Outdated Show resolved Hide resolved

lecocqp and others added 7 commits March 7, 2026 00:58

fix clang-format and remove leftovers

b205367

Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

relax new test error threshold

f88a271

Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Move legacy_texture_blur flag from ImageCacheImpl to TextureSystemImpl

9a73c69

Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Enable texture blur fix for OIIO versions >= 3.2.0

2ab30fb

Co-authored-by: Larry Gritz <lg@larrygritz.com> Signed-off-by: Pascal Lecocq <pascal.lecocq@gmail.com>

Apply suggestion from @lgritz

3b254ae

Signed-off-by: Larry Gritz <lg@larrygritz.com>

lgritz force-pushed the fix-texture-blur-overestimate branch from 7d4194d to 3b254ae Compare March 7, 2026 08:58

lgritz merged commit 30142ed into AcademySoftwareFoundation:main Mar 7, 2026
63 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(texture): fix texture overblur with st-blur parameters#5071

fix(texture): fix texture overblur with st-blur parameters#5071
lgritz merged 7 commits intoAcademySoftwareFoundation:mainfrom
lecocqp:fix-texture-blur-overestimate

lecocqp commented Mar 5, 2026 •

edited by lgritz

Loading

Uh oh!

linux-foundation-easycla bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

lecocqp commented Mar 6, 2026

Uh oh!

lgritz commented Mar 6, 2026

Uh oh!

lgritz Mar 6, 2026

Uh oh!

lgritz left a comment

Uh oh!

lecocqp commented Mar 7, 2026

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

Uh oh!

lgritz left a comment

Uh oh!

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		} else if (name == "legacy_texture_blur" && type == TypeDesc::INT) {
		m_legacy_texture_blur = ((const int)val != 0);

Conversation

lecocqp commented Mar 5, 2026 • edited by lgritz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist:

Uh oh!

linux-foundation-easycla bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lecocqp commented Mar 6, 2026

Uh oh!

lgritz commented Mar 6, 2026

Uh oh!

lgritz Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

lgritz left a comment

Choose a reason for hiding this comment

Uh oh!

lecocqp commented Mar 7, 2026

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

Uh oh!

lgritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

lgritz commented Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lecocqp commented Mar 5, 2026 •

edited by lgritz

Loading

linux-foundation-easycla bot commented Mar 5, 2026 •

edited

Loading