fix(jpeg2000): Watch out for int overflow in buffer size computation#5143
Merged
lgritz merged 2 commits intoAcademySoftwareFoundation:mainfrom Apr 23, 2026
Merged
fix(jpeg2000): Watch out for int overflow in buffer size computation#5143lgritz merged 2 commits intoAcademySoftwareFoundation:mainfrom
lgritz merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added
bug
Collaborator
Author
|
This is a week old. Any comments or objections? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent integer overflow when computing the pixel buffer size for JPEG2000 (OpenJPH) image reads.
Changes:
- Changes the buffer size computation in
ojph_read_image()fromintarithmetic tosize_tarithmetic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Because I just modified this PR slightly, I will give more time to receive comments. But because it's gone 10 days without objections on everything but the 4 statements I just added, I'm giving it just one more full day. I want to get this merged with plenty of time to be included in the May 1 patch release. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 23, 2026
…cademySoftwareFoundation#5143) Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 23, 2026
…cademySoftwareFoundation#5143) Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.