Skip to content

fix(fmath.h): typo in convert_type default argument, min() to max()#5227

Merged
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
luna-y-kim:fmath-convert-type-fix
Jun 5, 2026
Merged

fix(fmath.h): typo in convert_type default argument, min() to max()#5227
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
luna-y-kim:fmath-convert-type-fix

Conversation

@luna-y-kim
Copy link
Copy Markdown
Contributor

Description

Fix typo in convert_type default argument. Fixes #5223

Tests

N/A

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have read the Policy on AI Coding Assistants
    and if I used AI coding assistants, I have an Assisted-by: TOOL / MODEL
    line in the pull request description above.
  • (N/A) I have updated the documentation if my PR adds features or changes
    behavior.
  • (N/A) I am sure that this PR's changes are tested in the testsuite.
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.
  • (N/A) If I added or modified a public C++ API call, I have also amended the
    corresponding Python bindings. If altering ImageBufAlgo functions, I also
    exposed the new functionality as oiiotool options.

Signed-off-by: Luna Kim <177369799+luna-y-kim@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@lgritz lgritz merged commit 1735591 into AcademySoftwareFoundation:main Jun 5, 2026
28 checks passed
@luna-y-kim luna-y-kim deleted the fmath-convert-type-fix branch June 5, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: convert_type has the default argument max set to numeric_limits<D>::min() instead of ::max()

2 participants