Skip to content

Conversation

@gaida-exe
Copy link
Contributor

Since Ken mentioned that he wants angle brackets, I also created an angle bracket PR and this would be the counterpart to #1363.

It shortens the relative paths that could be shortened and unifies all not relative paths to use angle brackets.

Signed-off-by: Sebastian Gaida <sebastian-gaida@gmx.de>
Signed-off-by: Sebastian Gaida <sebastian-gaida@gmx.de>
@gaida-exe gaida-exe changed the title Angle brackets Use angle brackets for non-relative paths Aug 22, 2022
Copy link
Contributor

@e4lam e4lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks ok to me then!

@gaida-exe
Copy link
Contributor Author

Sorry for the ping, but would be great, if you could run the CI and maybe take a look.
(you took a look at the previous PR #1363)
@jmlait @Idclip @danrbailey

@gaida-exe
Copy link
Contributor Author

I've just pulled master without conflicts, because the CI failed. Maybe this can fix the issues. On Windows TBB was missing.
(failed Action)

Copy link
Contributor

@kmuseth kmuseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I have no ides why the NanoVDB unit-tests are failing - it looks like a CI installation issue related to CUDA drivers. In other words, nothing related to this PR

@kmuseth
Copy link
Contributor

kmuseth commented Oct 12, 2022

can you try this in your fork:

git fetch upstream
git merge upstream/master
git push origin angle-brackets

assuming you previously did

git remote add upstream git@github.com:AcademySoftwareFoundation/openvdb.git

@gaida-exe
Copy link
Contributor Author

Thanks for the suggestion Ken, but the branch is already merged with the latest commit of the upstream OpenVDB version (0efd583)
And as said, only the non-related NanoVDB build is failing, because of CUDA.
I don't know if it would change anything, but maybe rerunning the CI without a change could work, if something blocked the install.

@kmuseth kmuseth merged commit 4ffb9bc into AcademySoftwareFoundation:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants