-
Notifications
You must be signed in to change notification settings - Fork 731
Use angle brackets for non-relative paths #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use angle brackets for non-relative paths #1418
Conversation
Signed-off-by: Sebastian Gaida <sebastian-gaida@gmx.de>
Signed-off-by: Sebastian Gaida <sebastian-gaida@gmx.de>
e4lam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks ok to me then!
|
Sorry for the ping, but would be great, if you could run the CI and maybe take a look. |
|
I've just pulled master without conflicts, because the CI failed. Maybe this can fix the issues. On Windows TBB was missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I have no ides why the NanoVDB unit-tests are failing - it looks like a CI installation issue related to CUDA drivers. In other words, nothing related to this PR
|
can you try this in your fork: assuming you previously did
|
|
Thanks for the suggestion Ken, but the branch is already merged with the latest commit of the upstream OpenVDB version (0efd583) |
Since Ken mentioned that he wants angle brackets, I also created an angle bracket PR and this would be the counterpart to #1363.
It shortens the relative paths that could be shortened and unifies all not relative paths to use angle brackets.