Skip to content

Conversation

@rex4539
Copy link

@rex4539 rex4539 commented Jan 15, 2025

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 15, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rex4539 / name: Dimitris Apostolou (4cd6c98)

@swahtz
Copy link
Contributor

swahtz commented Jan 27, 2025

Thanks for this! Looks like a few of the changes apply to variable/function names so might get some more eyes on the changes.

Copy link
Contributor

@danrbailey danrbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could find just one case where a struct was being changed that should not. Otherwise, I'm happy for this to be merged in.

@rex4539 rex4539 requested a review from danrbailey February 5, 2025 19:15
@rex4539 rex4539 requested a review from danrbailey February 6, 2025 22:32
@rex4539
Copy link
Author

rex4539 commented Feb 6, 2025

I could find just one case where a struct was being changed that should not. Otherwise, I'm happy for this to be merged in.

Is it ok now or you still need some changes?

@rex4539
Copy link
Author

rex4539 commented Feb 13, 2025

Fixed some more typos, from the new code that has been added recently.

Copy link
Contributor

@swahtz swahtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a read through of these changes and can confirm there are now no changes to signatures or class names; all the changes are to comments, documentation, error messages and the like minus 2 changes to local variable naming for typos.

Thanks for this contribution! I think a next step might be for us to instrument an action that checks for these kinds of typos so they don't creep back in as we develop. Perhaps an action like https://github.com/marketplace/actions/typos-action

Copy link
Contributor

@jmlait jmlait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change interation -> iteration rather than interaction :>

There are two places where real-code is changed, but I've validated both are safe.

Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
@rex4539
Copy link
Author

rex4539 commented May 3, 2025

Closing due to no interest.

@rex4539 rex4539 closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants