-
Notifications
You must be signed in to change notification settings - Fork 728
Fix typos #1995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #1995
Conversation
|
|
|
Thanks for this! Looks like a few of the changes apply to variable/function names so might get some more eyes on the changes. |
danrbailey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could find just one case where a struct was being changed that should not. Otherwise, I'm happy for this to be merged in.
Is it ok now or you still need some changes? |
|
Fixed some more typos, from the new code that has been added recently. |
swahtz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a read through of these changes and can confirm there are now no changes to signatures or class names; all the changes are to comments, documentation, error messages and the like minus 2 changes to local variable naming for typos.
Thanks for this contribution! I think a next step might be for us to instrument an action that checks for these kinds of typos so they don't creep back in as we develop. Perhaps an action like https://github.com/marketplace/actions/typos-action
jmlait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change interation -> iteration rather than interaction :>
There are two places where real-code is changed, but I've validated both are safe.
|
Closing due to no interest. |
No description provided.