Get rid of FORI, FORJ, FORIJ and clear warnings #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 74.20% 74.39% +0.18%
==========================================
Files 10 10
Lines 2198 2226 +28
Branches 237 292 +55
==========================================
+ Hits 1631 1656 +25
- Misses 567 570 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
soswow
changed the title
antond-weta
reviewed
Sep 13, 2025
src/rawtoaces_core/mathOps.h
Outdated
| template <typename T> vector<T> invertV( const vector<T> &vMtx ) | ||
| { | ||
| int size = std::sqrt( static_cast<int>( vMtx.size() ) ); | ||
| size_t size = std::sqrt( static_cast<size_t>( vMtx.size() ) ); |
Contributor
There was a problem hiding this comment.
do we still need this cast?
antond-weta
reviewed
Sep 13, 2025
| const SpectralData &camera, | ||
| const SpectralData &illuminant, | ||
| const SpectralData &camera, | ||
| const SpectralData & /* illuminant */, |
Contributor
There was a problem hiding this comment.
maybe remove the parameter completely, if it's not needed
antond-weta
approved these changes
Sep 13, 2025
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
antond-weta
reviewed
Sep 14, 2025
| settings.auto_bright = arg_parser["auto-bright"].get<int>(); | ||
| settings.adjust_maximum_threshold = | ||
| arg_parser["adjust-maximum-threshold"].get<int>(); | ||
| static_cast<float>( arg_parser["adjust-maximum-threshold"].get<int>() ); |
Contributor
There was a problem hiding this comment.
I think this should be get<float>
Contributor
Author
There was a problem hiding this comment.
yeah. I believe @mikaelsundell has fixed that in his branch. We can merge as it is now if rest is ok, and he will fix it up in merge conflict stage. he woul dhave merge conflict regardless if I fix it now
antond-weta
approved these changes
Sep 14, 2025
Signed-off-by: Aleksandr Motsjonov <soswow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.