-
Notifications
You must be signed in to change notification settings - Fork 56
add native rawtoaces CI runners #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native rawtoaces CI runners #213
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 10 10
Lines 2114 2114
Branches 317 317
=======================================
Hits 1534 1534
Misses 580 580 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
da601d2 to
0c669f9
Compare
472a39e to
1f83173
Compare
| - vfxyear: 2024 | ||
| container: aswf/ci-osl:2024-clang17 | ||
| container: aswf/ci-rawtoaces:2024.4 | ||
| toolchain_file: "/__w/rawtoaces/rawtoaces/build_deps/conan_toolchain.cmake" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these seem to be absolute and rather magical paths. are we sure in those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's where we install the dependencies to in a preceding step conan install --output-folder=build_deps
That step shouldn't be necessary at all, as the rawtoaces-specific containers come with all deps preinstalled. Hopefully we'll resolve the issues soon and remove this.
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
1f83173 to
4967f69
Compare
Description
Add native CI runners (aswf/ci-rawtoaces) for VFX year 2024, 2025, 2026.
Tests
No changes to the code
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.