Skip to content

A spelling mistake in ampligraph/latent_features/models/EmbeddingModel.py or documentation causes the training model different the documentation's #258

@Wlz-Hit

Description

@Wlz-Hit

Description

The spelling mistake in ampligraph/latent_features/models/EmbeddingModel.py or documentation causes the the strategy of generating corruptions is allways default('s,o').

Actual Behavior

I want to build a TransE model, when generates corruptions only changing tail entity.
After read the documentation, I passed the parameter embedding_model_params={'corrupt_sides': 'o'} to the TransE function to build the model.
When I single step debugging, I find that the strategy of generating corruptions is allways default('s,o').
The bug is caused by EmbeddingModel.py 667 line code corruption_sides = self.embedding_model_params.get('corrupt_side', constants.DEFAULT_CORRUPT_SIDE_TRAIN) . In this line, the variable self.embedding_model_params tries to get the value of key corrupt_side, but the documentation's key is corrupt_sides.

Solution

To solve the bug, we could pass the the parameter embedding_model_params={'corrupt_side': 'o'} to the TransE function instead of the documentation's parameter.
This is a serious mistake, fortunately,it is easy to solve, so I hope you could correct it quickly.

Thank you!

Metadata

Metadata

Assignees

Labels

quality & documentationCoding conventions compliance, unit tests, documentation

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions