feat: create github ci template for lenscore accessibility testing #24

Caknoooo · 2025-10-30T03:55:33Z

No description provided.

4rokis

@Caknoooo Can you as part of the test for this template add it to the Access TIme Web V2 repo?

4rokis · 2025-10-30T03:58:20Z

@Caknoooo SHould be a comment not request for changes

Caknoooo · 2025-10-30T03:59:57Z

@Caknoooo SHould be a comment not request for changes

This means that the one that was tried to scan etc. was AccessTime Web V2, right?

mneysa · 2025-10-30T04:07:47Z

.github/workflows/lens-core.yml

+      - name: Deploy with Vercel (if mode=vercel)
+        id: vercel_deploy
+        if: ${{ inputs.mode == 'vercel' }}
+        uses: amondnet/vercel-action@v25


Is there official vercel action library ? let's try not use unofficial vercel action if possible.

Okay ce. I'll explore official action

mneysa · 2025-10-30T04:08:32Z

.github/workflows/lens-core.yml

+        description: 'Deployment mode: vercel | nextjs | custom'
+        required: true
+        type: string
+      url:
+        description: 'Target URL to scan (if already deployed/known)'
+        required: false
+        type: string
+      build-command:
+        description: 'Build command for nextjs/custom'
+        required: false
+        type: string
+        default: 'npm run build'
+      start-command:
+        description: 'Start command for nextjs/custom'
+        required: false
+        type: string
+        default: 'npm start'
+      port:
+        description: 'Local port the app listens to (nextjs/custom)'
+        required: false
+        type: number
+        default: 3000
+      scan-depth:
+        description: 'Max crawl depth'
+        required: false
+        type: number
+        default: 2
+      max-urls:
+        description: 'Max URLs to crawl'
+        required: false
+        type: number
+        default: 10
+      timeout:
+        description: 'Request timeout (ms)'
+        required: false
+        type: number
+        default: 15000
+      use-web-report:
+        description: 'Generate HTML report in addition to JSON'
+        required: false
+        type: boolean
+        default: true
+      fail-on-violations:
+        description: 'Fail CI when violations > 0'
+        required: false
+        type: boolean
+        default: true
+      vercel-project-path:
+        description: 'Relative path to the Vercel project (for monorepo)'
+        required: false
+        type: string
+        default: '.'
+      vercel-environment:
+        description: 'Vercel environment: preview | production'
+        required: false
+        type: string
+        default: 'preview'


@Caknoooo let's minimize the inputs and move it to GH Environment variables instead. It's quite bothersome to keep needing to change the settings if its put as an input (https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables).

Let's leave mode and url only as input, as those are the one that potentially will need to be customized often, but don't use string as type, use choice (https://github.blog/changelog/2021-11-10-github-actions-input-types-for-manual-workflows/) so user can just choose.

4rokis

Just a small think that I believe would make it so much cleaner.

@mneysa WDYT?

4rokis · 2025-11-02T22:21:11Z

.github/workflows/lens-core.yml

+  workflow_call:
+    inputs:
+      mode:
+        description: 'Deployment mode (vercel | nextjs | custom)'


@Caknoooo This is more clear now and easier to read. However, I would go a step further and split it into 3 templates. vercel-lens-core-template.yml, nextjs-lens-core-template.yml , lens-core-template.yml. There will be a lot of shared and duplicated code but it will be much cleaner and easier for the final user to reuse.

As well place it to a diferent location as in this one it runs on lens-core as well 😅 Something like github-templates or something like that.

4rokis · 2025-11-02T22:22:08Z

.github/workflows/vercel-lens-core-template.yml

+        type: string
+    secrets:
+      VERCEL_TOKEN:
+        required: false


Can we somehow make it that only the the required secret is a secret? Vercel topken should be a secret but org and project id should not

Ohhh. That makes sense. I'll fix it

4rokis

SOme comments that need explanation

4rokis · 2025-11-04T22:25:59Z

.github/workflows/lens-core-template.yml

+          import sys
+          import re
+
+          with open('/tmp/scan-output.txt', 'r') as f:


@Caknoooo Why is this needed? It reads the output and saves it into json? Why is this not done on the lens-core level?

Ohhh sorry, I didn't notice this scan was still there. I'll fix it and try it on accesstime V2

4rokis · 2025-11-04T22:27:53Z

README.md

+      url: ''
+    secrets:
+      VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
+      VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}


@Caknoooo This is not updated

Ohh my bad. I'll fix it

4rokis · 2025-11-04T22:28:43Z

README.md

+
+jobs:
+  accessibility:
+    uses: Access-Time/LensCore/.github/workflows/lens-core.yml@main


@Caknoooo Where does it takes this from? If I am adding it to my project. How does it know what Access-Time/LensCore is?

I forgot to update the documentation. Maybe I'll fix and testing first and I'll update the documentation

4rokis · 2025-11-04T22:29:35Z

@Caknoooo Can you add a PR to the AccessTIme web v2 with the vercel template? So we can see if and how it works?

Caknoooo · 2025-11-05T00:25:18Z

@Caknoooo Can you add a PR to the AccessTIme web v2 with the vercel template? So we can see if and how it works?

Sure, I'll try this

4rokis · 2025-11-07T02:59:40Z

@Caknoooo What's the status of adding it to web-v2? We need to see it in action :)

Caknoooo · 2025-11-08T12:54:42Z

@Caknoooo What's the status of adding it to web-v2? We need to see it in action :)

Do you know how to invoke this CI on another repository?

I've tried creating a pull request here, but the workflows aren't working.
https://github.com/Access-Time/web-v2/pull/23

4rokis · 2025-11-08T21:33:53Z

@Caknoooo Can you ping @mneysa on this she might know more about it

4rokis · 2025-11-10T08:37:08Z

@Caknoooo There is still some issue with the template. Please look into it. Let's block this patch till we get a green light from the CI on the web

4rokis · 2025-11-12T14:12:29Z

.github/workflows/vercel-lens-core-template.yml

+          if [ "$SCAN_RESULTS" -eq 0 ]; then
+            echo "::warning::No pages were scanned. Check if the application is running and accessible."
+          fi
+


@Caknoooo We have a lot of set up here. Is there are way to extract it and share?

4rokis · 2025-11-12T14:13:51Z

.github/workflows/nextjs-lens-core-template.yml

+      # -------------------------
+      # CHECK VIOLATIONS
+      # -------------------------
+      - name: Check for violations


@Caknoooo Why do we need this? This seems too much custom logic. IMHO we should move this to the LensCore itself. We basically creating a text output no?

@4rokis Yes, currently I am still in the research stage and it is not finished yet.

4rokis · 2025-11-14T13:48:39Z

@Caknoooo What's the status? Is it ready for review?

Caknoooo · 2025-11-17T13:09:48Z

@Caknoooo What's the status? Is it ready for review?

@4rokis Maybe can review now

Using npm: https://github.com/vronnn/ts-nextjs-tailwind-travel/actions/runs/19369682617/job/55421966612
Using npm and no violations: https://github.com/Caknoooo/access-time/actions/runs/19362947675/job/55399052401
Using pnpm: web v-2
Using yarn: https://github.com/Caknoooo/compfest-movie-ticketing-frontend/actions/runs/19430641333/job/55588482581

mneysa · 2025-11-21T05:46:05Z

.github/workflows/lens-core-template.yml

+            fi
+            echo "✓ Created basic Dockerfile for $PM"
+          else
+            echo "✓ Using existing Dockerfile"


tbh, this is unnecessary, we should assume that user will have their own Dockerfile already, and if they not, then they should create one. We should not create template dockerfile for them because this most likely won't even work for their infrastructure and they will be forced to create their own Dockerfile.

I will just remove this and leave it with checking for Dockerfile file in the repo.

Okey cee 👍

4rokis · 2025-11-24T05:48:22Z

@Caknoooo @mneysa What's the status?

Caknoooo · 2025-11-24T07:43:13Z

@Caknoooo @mneysa What's the status?

Was the desired approach implemented? @mneysa

Caknoooo self-assigned this Oct 30, 2025

Caknoooo linked an issue Oct 30, 2025 that may be closed by this pull request

Create GitHub CI Template for LensCore Accessibility Testing #13

Open

7 tasks

Caknoooo requested review from 4rokis, ahda-hr and mrevanzak October 30, 2025 03:55

4rokis requested changes Oct 30, 2025

View reviewed changes

mneysa reviewed Oct 30, 2025

View reviewed changes

Caknoooo force-pushed the feat/create-github-ci-template-for-lenscore-accessibility-testing branch from e8af32f to 77d42b2 Compare November 2, 2025 09:03

Caknoooo requested review from 4rokis and mneysa November 2, 2025 09:16

4rokis requested changes Nov 2, 2025

View reviewed changes

Caknoooo requested a review from 4rokis November 4, 2025 14:33

4rokis requested changes Nov 4, 2025

View reviewed changes

Caknoooo added 9 commits November 12, 2025 10:34

feat: create github ci template for lenscore accessibility testing

6715282

style: run formatter

ac9cec9

ci: optimizing implementation for lens core ci

3eb1b42

style: run formatter

98ad085

feat: create scalable ci lens-core for accessibility open source

9eae81a

docs: update url path readme

59d2342

feat: splitting and handle vercel token required

e78e428

feat: add cli output file json and adjust something

c488ce4

docs: update readme

61362e9

4rokis reviewed Nov 12, 2025

View reviewed changes

Caknoooo added 15 commits November 12, 2025 22:02

ci: change approach

e9a09d7

ci: change approach

8a82b81

ci: change approach

ec6ebd1

feat: change approach of lens-core

4d00fd1

feat: change approach of lens-core

b0c2a39

feat: change approach of lens-core

711935d

feat: change approach of lens-core

deeba9d

feat: change approach of lens-core

e939ed5

feat: change approach of lens-core

e996a5a

feat: change approach of lens-core

1bb3e19

feat: change approach of lens-core

2e4f326

feat: change approach of lens-core

0d02333

feat: change approach of lens-core

13f617e

ci: change approach

8bcd4da

ci: change approach

b6b2823

Caknoooo added 6 commits November 15, 2025 00:27

ci: change yarn version

4d96c05

ci: change approach for yarn

e66f33d

ci: change approach for yarn

dcae4ae

ci: fix yarn install package

0bc337b

ci: fix yarn install package

19eb3ae

ci: fix yarn install package

1fcd1d7

Caknoooo requested a review from 4rokis November 17, 2025 13:10

ci: cleaning implementation scan template

16c1459

mneysa reviewed Nov 21, 2025

View reviewed changes

feat: create github ci template for lenscore accessibility testing #24

Are you sure you want to change the base?

feat: create github ci template for lenscore accessibility testing #24

Conversation

Caknoooo commented Oct 30, 2025

Uh oh!

4rokis left a comment

Choose a reason for hiding this comment

Uh oh!

4rokis commented Oct 30, 2025

Uh oh!

Caknoooo commented Oct 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rokis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rokis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rokis commented Nov 4, 2025

Uh oh!

Caknoooo commented Nov 5, 2025

Uh oh!

4rokis commented Nov 7, 2025

Uh oh!

Caknoooo commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

4rokis commented Nov 8, 2025

Uh oh!

4rokis commented Nov 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rokis commented Nov 14, 2025

Uh oh!

Caknoooo commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

4rokis commented Nov 24, 2025

Uh oh!

Caknoooo commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Caknoooo commented Nov 8, 2025 •

edited

Loading

Caknoooo commented Nov 17, 2025 •

edited

Loading