Removed duplicated code from GenericConsumer #1
Closed
aranm wants to merge 1 commit intoAccess4Learning:masterfrom
Closed
Removed duplicated code from GenericConsumer #1aranm wants to merge 1 commit intoAccess4Learning:masterfrom
aranm wants to merge 1 commit intoAccess4Learning:masterfrom
Conversation
Contributor
|
A more generic solution to logging is currently being investigated which will deprecated this pull request. As such, this pull request will be closed. A new develop branch has also been created for making future pull requests against. |
rafidzal
pushed a commit
that referenced
this pull request
Jul 18, 2016
Addition of Functional Services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a lot of duplicated code in the GenericConsumer class related to logging.
I pulled it into a single method for the following reasons: