Skip to content

Removed duplicated code from GenericConsumer #1

Closed
aranm wants to merge 1 commit intoAccess4Learning:masterfrom
aranm:master
Closed

Removed duplicated code from GenericConsumer #1
aranm wants to merge 1 commit intoAccess4Learning:masterfrom
aranm:master

Conversation

@aranm
Copy link
Copy Markdown

@aranm aranm commented Nov 27, 2014

There was a lot of duplicated code in the GenericConsumer class related to logging.
I pulled it into a single method for the following reasons:

  1. The code was duplicated.
  2. I think a customisable logger should be able to be used. I don't think the framework should have a dependency on a particular logger, you should be able to use any you choose to. If the logger is only referenced once in the file it would make this easier to implement.

@rafidzal
Copy link
Copy Markdown
Contributor

A more generic solution to logging is currently being investigated which will deprecated this pull request. As such, this pull request will be closed.

A new develop branch has also been created for making future pull requests against.

@rafidzal rafidzal closed this Sep 18, 2015
rafidzal pushed a commit that referenced this pull request Jul 18, 2016
Addition of Functional Services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants