Main to develop - #302
Merged
Merged
Conversation
Add duplication menu action on cmd+d
# Conflicts: # VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift
Routing refactoring
Presentation redesign
… reaction speed on button’s press
…-minimum-windows-height 274 adjustable values increases minimum windows height
Scroll to selected item it list too long to fit on screen
Add Library name to Document class to fix File -> Open menu
Fix sound on escape button on macos
# Conflicts: # Shared/Sources/Canvas/CanvasPresenter.swift # Shared/Sources/Canvas/Drawing/DrawingView.swift # Shared/Sources/Document/Accessibility/Protocols/AccessibilityView/AccessibilityView+Grouping.swift # Shared/Sources/Document/Documents/Document/VODesignDocumentProtocol.swift # Shared/Sources/Document/Models/Protocols/A11yContainer.swift # Shared/Sources/Document/Models/Protocols/AccessibilityViews.swift # VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasView.swift # VoiceOver Designer/Features/Sources/CanvasAppKit/CanvasViewController.swift # VoiceOver Designer/Features/Sources/Recent/RecentViewController/UI/DocumentsBrowserViewController.swift # VoiceOver Designer/Features/Sources/Settings/States/Element/ElementSettingsViewController.storyboard # VoiceOver Designer/Features/Tests/CanvasAppKitTests/Base/CanvasPresenterTests.swift # VoiceOver Designer/Features/Tests/CanvasAppKitTests/CancellingActionsTests.swift # VoiceOver Preview/PreviewFeatures/Sources/CanvasUIKit/Canvas.swift
akaDuality
commented
Nov 1, 2023
|
|
||
| public init( | ||
| elements: [A11yDescription], | ||
| id: UUID = UUID(), |
Member
Author
There was a problem hiding this comment.
Remove default to make it explicit and avoid potential bugs
Collaborator
There was a problem hiding this comment.
What bugs should come with default value?
You thinking that ids could be equal if we create id for already created file?
|
|
||
| import Foundation | ||
|
|
||
| extension ArtboardElement { |
| newDocumentIsCreated = true | ||
|
|
||
| let split = ProjectController(document: document, router: self) | ||
| // TODO: Check that this document is not opened in another tab |
| addChild(newController) | ||
| view.addSubview(newController.view) | ||
| view.pinToBounds(newController.view) | ||
| // newController.didMove(toParent: self) |
| } | ||
|
|
||
| func test_createControlsWhenDocumentImageNil() { | ||
| // TODO: Remove image? |
| import AppKit | ||
| import Presentation | ||
| import SwiftUI | ||
| import Settings // TODO: Move StateViewController out of settings |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.