Revert AppKit settings - #339
Merged
Merged
Conversation
akaDuality
force-pushed
the
reventAppKitSettings
branch
from
May 1, 2024 19:48
3d0dd87 to
8beaa87
Compare
This was referenced May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftUI's views are extremely slow: 200 ms on M1 Pro processor to open an element's settings. It's visible lag! AppKit shows the screen by 20 ms, 10 times faster.
Revert AppKit views and add a feature flag to switch between AppKit and SwiftUI.
Fun fact: the mistake starts from the unclosed checklist at #322
TODO