fix(admob): harden consent, banners, and variant builds - #2553
Merged
Conversation
- integrate UMP consent handling and reactive privacy choices - serialize adaptive banner visibility across pages and keyboard changes - make free and paid Cordova variant configuration idempotent - commit and validate a deterministic self-contained AdMob bundle - remove vulnerable legacy toolchains and update affected lockfiles - replace the legacy soft-input workaround with adjustResize - add tests, lockfile checks, bundle freshness, and security auditing to CI
deadlyjack
requested review from
RohitKushvaha01 and
bajrangCoder
and removed request for
bajrangCoder
July 30, 2026 16:02
Contributor
Greptile SummaryThe PR hardens AdMob consent and banner lifecycle handling while making Android variants and generated assets deterministic.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported rewarded-pass expiry issue is addressed by clearing its named suppression during refreshed expiry-state application and reconciling the shared banner controller. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
RewardState[Reward state refresh] --> RewardPolicy[Reward-pass policy]
RewardPolicy --> Suppression[Named banner suppressions]
ProState[Pro purchase state] --> Suppression
Page[Active registered page] --> Controller[Banner visibility controller]
Keyboard[Keyboard visibility] --> Controller
Suppression --> Controller
Controller -->|eligible| Show[Show native banner]
Controller -->|suppressed or ineligible| Hide[Hide native banner]
Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/admob-conse..." | Re-trigger Greptile |
- make banner suppression reason-aware across Pro and rewarded passes - centralize reward state refresh, expiry scheduling, and failure handling - remove stale Cordova consent and persisted AdMob variant metadata - add ES2020-compatible access and Java 21 Android native CI coverage - enforce transient plugin setup and clean tracked build state - remove the obsolete large-screen quicktools tutorial
This comment was marked as outdated.
This comment was marked as outdated.
RohitKushvaha01
approved these changes
Jul 31, 2026
added 2 commits
August 2, 2026 21:10
…ner-variants # Conflicts: # bun.lock # config.xml # package-lock.json
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
# Conflicts: # config.xml
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.