feat(editor): add configurable horizontal scroll margin to CodeMirror - #2569
Merged
Conversation
1 task
Contributor
Greptile SummaryAdds a configurable horizontal scroll margin for unwrapped CodeMirror editors.
Confidence Score: 4/5The PR appears safe to merge, with the non-blocking caveat that the new setting remains untranslated in every non-English locale. The editor setting, compartment reconfiguration, and scrollbar integration are coherently wired; the only accepted issue is duplicated English UI copy in localized language bundles. Files Needing Attention: src/lang/*.json Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Settings[Scroll settings: leftMargin] --> Store[appSettings.update]
Store --> Event[update:leftMargin]
Event --> Options[applyOptions textWrap]
Options --> Wrap{Word wrap enabled?}
Wrap -->|Yes| LineWrap[EditorView.lineWrapping]
Wrap -->|No| Margin[horizontalScrollPastEnd]
Margin --> Padding[Right padding on cm-content]
Padding --> Width[scrollDOM.scrollWidth]
Width --> Scrollbar[Horizontal scrollbar range]
Reviews (1): Last reviewed commit: "." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #2398 #2277